repremium/mokosh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(04-06): A35 live-DOM inline-SVG harness check + A17.8 raw-source update + back-patch

Browse Source 
Closes the iter-2 BLOCKER 1 resolution end-to-end: the inline-SVG
strategy now has HONEST automated coverage at two layers — source
contract (Task 1 unit tests + the narrowed A17.8 source-bundling
grep) and live-DOM cascade (the NEW host-side A35 harness assertion
that opens welcome.html as a real Puppeteer tab).

- tests/uat/extension-page-harness.ts (A17.8 NARROWED HONESTLY):
  swap the data:image/svg+xml URL-grep + .svg filename-grep target
  for a raw-source grep — A17.8 now asserts the welcome chunk JS
  contains the raw SVG signature `stroke="currentColor"` AND the
  canonical `viewBox="0 0 32 32"` (the `?raw` import's output). The
  explanatory comment block now DISAVOWS the live-DOM claim and
  points at the NEW A35 driver for the runtime injection + cascade
  proof. A17.8 is honest source-bundling only.
- tests/uat/lib/harness-page-driver.ts (NEW host-side driveA35):
  appended LAST per the iter-2 ADV-2C concern (any driver-pollution
  worry is moot since nothing reads A35's return value, AND
  welcomePage.close() in finally guarantees no tab leak). driveA35
  opens chrome-extension://<id>/src/welcome/welcome.html in a fresh
  browser.newPage() tab, waits for the `.welcome-hero__mark svg`
  selector at DOMContentLoaded, then runs a single page.evaluate()
  that reads four signals: A35.1 inline <svg> present, A35.2
  stroke=currentColor, A35.3 getComputedStyle().stroke resolves to
  a non-default colour (the real cascade proof), A35.4 no legacy
  <img> in the slot. Host-side pattern mirrors driveA32/A33/A34.
- tests/uat/harness.test.ts (orchestrator wiring):
  + driveA35 added to the import block from './lib/harness-page-driver'.
  + driveA35Wrapped closure capturing handles.browser + handles.extensionId
    (alongside driveA33Wrapped/driveA34Wrapped).
  + { name: 'A35', drive: driveA35Wrapped } appended as the LAST
    entry of the `drivers` array. Total auto-increments via
    `drivers.length + 1` (line 580) — no hardcoded count to bump.
  + Architecture banner string (line 283) refreshed with A33, A34,
    A35 inline (ADV-2A cosmetic advisory — banner was already stale
    pre-04-06; A33+A34 added at the same time).
- .planning/phases/01-stabilize-video-pipeline/01-07-SUMMARY.md
  (back-patch, DEFECT 2 resolution):
  Flipped 5 lines (22, 47, 82, 135, 205) that carried the now-stale
  "deferred to Phase 5" framing for cursor visibility — the
  `cursor: 'always'` constraint was opportunistically shipped in
  Plan 01-09 (recorder.ts:285) and is verified by Plan 04-06 Task 1
  (tests/build/cursor-visibility.test.ts). Each flip is surgical
  (single line / single bullet, with explicit "back-patched in
  Phase 4 Plan 04-06" citation). Historical commit-description
  lines 40, 89, 109, 110 are LEFT unchanged — they describe what
  the Phase-1-closure commits literally did at the time, not
  forward-looking deferrals.
- .planning/phases/04-harden-clean-up-optional/deferred-items.md
  (correction, BLOCKER 2 resolution):
  Corrected the misdiagnosed entry from commit 6a989e8. The prior
  entry named tests/build/strict-meta-json-validation.test.ts as
  failing on a clean tree — that diagnosis was WRONG (the test is
  8/8 GREEN in isolation). The real root cause is the pre-existing
  04-CONTEXT #9 + #10 parallel-vitest / ffprobe-timeout flake
  family (lands non-deterministically on whichever ffprobe / race
  test loses the worker race; observed instance this session was
  tests/background/webm-remux.test.ts > ffprobe -count_frames,
  which is also 5/5 GREEN in isolation). True clean baseline is
  184/184 GREEN; 188/188 after Plan 04-06's +4 new tests.

Gates run:
- npx tsc --noEmit exit 0.
- npm run build:test exit 0; dist-test/assets/welcome-CMygHJ_J.js
  carries the raw SVG source.
- HEADLESS=1 SKIP_PROD_REBUILD=0 SKIP_LONG_UAT=1 npm run test:uat:
  36/36 UAT assertions GREEN (was 35/35; +A35). A17.8 PASS:
  currentColorStroke=true, canonicalViewBox=true. A35 live-DOM
  probe: svgPresent=true strokeAttr=currentColor
  computedStroke="rgb(250, 247, 241)" (linen-50, the
  --mks-fg-inverse value flowing through the cascade — the
  currentColor strategy WORKS in real Chrome) imgPresent=false.
- All Task 3 acceptance greps PASS: driveA35 count in
  harness-page-driver.ts=5, in harness.test.ts=6; name:'A35'=1;
  getComputedStyle=6; stroke="currentColor" in
  extension-page-harness.ts=4; data:image/svg+xml=0 (grep target
  and comment refs both removed).

References:
- 04-06-PLAN.md iter-2 BLOCKER 1 + BLOCKER 2 resolutions.
- .planning/phases/04-harden-clean-up-optional/04-UI-SPEC.md
  §"Implementation amendment" (Option A currentColor + inline-SVG).
This commit is contained in:
Mark
2026-05-26 08:48:43 +02:00
parent c4161431e7
commit 3f8e31a329
5 changed files with 235 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/uat/harness.test.ts
View File

@@ -112,6 +112,12 @@ import {
// Plan 04-05 — driveA34 fetch + XHR network_error empirical (ROADMAP SC #2;
// needs downloadsDir for host-side JSZip parse of logs/events.json).
driveA34,
// Plan 04-06 — driveA35 UI-SPEC dark-logo `currentColor` LIVE-DOM proof.
// Opens welcome.html in a fresh browser.newPage() tab so populateMark()
// actually runs; reads getComputedStyle().stroke on the injected <svg>
// to verify the currentColor cascade. Host-side driver — needs Browser +
// extensionId (mirrors driveA33's Browser+extensionId capture pattern).
driveA35,
getManifestVersion,
} from './lib/harness-page-driver';
import {
@@ -280,7 +286,7 @@ async function assertA0_GrepGate(): Promise<{
*/
async function main(): Promise<number> {
process.stdout.write('\nMokosh Plan 01-13 + 01-14 + 02-04 — UAT harness orchestrator\n');
process.stdout.write('Architecture: A0 pre-flight + extension-internal page driver (A1..A14, A15..A17, A18..A22, A23, A24, A25, A26, A27, A28, A29, A30, A31, A32)\n');
process.stdout.write('Architecture: A0 pre-flight + extension-internal page driver (A1..A14, A15..A17, A18..A22, A23, A24, A25, A26, A27, A28, A29, A30, A31, A32, A33, A34, A35)\n');
process.stdout.write('='.repeat(72) + '\n');
// A0 pre-flight (no Chrome launch needed; runs against built dist/).
@@ -370,6 +376,11 @@ async function main(): Promise<number> {
// logs/events.json (fetch + XHR network_error entry inspection).
const driveA34Wrapped: (page: import('puppeteer').Page) => Promise<AssertionRecord> =
(page) => driveA34(page, handles.downloadsDir);
// Plan 04-06 — driveA35 needs Browser + extensionId to open a fresh
// welcome.html tab via browser.newPage() (UI-SPEC dark-logo LIVE-DOM
// proof). Mirrors the driveA33 Browser+extensionId capture pattern.
const driveA35Wrapped: (page: import('puppeteer').Page) => Promise<AssertionRecord> =
(page) => driveA35(page, handles.browser, handles.extensionId);
const drivers: ReadonlyArray<{
readonly name: string;
@@ -532,6 +543,17 @@ async function main(): Promise<number> {
// chrome.scripting.executeScript ISOLATED-world. Runs ~25s (always
// RUN — not env-gated; the 5-min wait is A33's, not A34's).
{ name: 'A34', drive: driveA34Wrapped },
// Plan 04-06 A35: UI-SPEC dark-logo `currentColor` strategy LIVE-DOM
// proof. Opens welcome.html as a real Puppeteer tab so populateMark()
// actually runs; reads getComputedStyle().stroke on the injected
// <svg> to verify the currentColor cascade resolves through
// .welcome-hero__mark color: var(--mks-fg-inverse) (UI-SPEC Option A).
// Appended LAST in the drivers array so the new welcome tab cannot
// pollute any later driver (and welcomePage.close() in finally
// guarantees no tab leak regardless). Host-side driver — mirrors
// the driveA32/A33/A34 host-side pattern (NOT a page.evaluate
// (window.__mokoshHarness) wrapper).
{ name: 'A35', drive: driveA35Wrapped },
];
const buffers = { swConsole: handles.swConsole, offConsole: handles.offConsole };