diff --git a/.planning/phases/01-stabilize-video-pipeline/deferred-items.md b/.planning/phases/01-stabilize-video-pipeline/deferred-items.md new file mode 100644 index 0000000..d910c99 --- /dev/null +++ b/.planning/phases/01-stabilize-video-pipeline/deferred-items.md @@ -0,0 +1,42 @@ +# Phase 01 Deferred Items + +Out-of-scope discoveries surfaced during plan execution that didn't directly +caused-by the current plan's changes. Per `` SCOPE +BOUNDARY: log here, don't fix. + +## Plan 01-12 (Wave 7 pre-checkpoint bundle gates discovery) + +### `new Function("" + I)` reachable in SW chunk via setimmediate polyfill + +- **Discovered:** 2026-05-20 during Wave 7 pre-checkpoint bundle gates +- **Location:** `dist/assets/index.ts-.js` (the main SW chunk produced + by `npm run build`) +- **Context:** `vite-plugin-node-polyfills` (configured in + `vite.config.ts:nodePolyfills` for `Buffer`) bundles the upstream `setimmediate` + package which contains the construct: `b.setImmediate=function(I){typeof + I!="function"&&(I=new Function(""+I));...}`. The `new Function` is the + fallback when `setImmediate` is called with a non-function argument. +- **Reachability check:** Production code path `src/background/index.ts` + + `src/offscreen/recorder.ts` + their transitive deps DO NOT call + `setImmediate(string)`. The construct is dead in the static call graph + but Rollup conservatively preserves it (it's behind a runtime type + check, not a static dead branch). +- **MV3 CSP angle:** Modern Chrome (≥ MV3) does enforce CSP `script-src + 'self'`, and `new Function('...')` evaluates a string-as-code which + some CSPs reject. However, the default MV3 manifest's + `content_security_policy` allows it for service workers in current + Chrome — Plan 01-12 did NOT introduce a tighter CSP override, so + this is benign at present. +- **Scope:** Pre-existing across all of Phase 1 history. Verified by + `git checkout main -- src/background/index.ts vite.config.ts && + npm run build && grep -c 'new Function' dist/assets/index.ts-*.js` + returning the same count. Plan 01-12 made no changes to the + polyfill configuration; this entry exists for future tightening + (Phase 5 hardening, or a dedicated MV3 CSP-audit plan). +- **Suggested follow-up:** Switch from `vite-plugin-node-polyfills`'s + full `Buffer` polyfill to a tree-shake-friendly minimal Buffer + shim — or audit downstream deps for direct `Buffer.*` usage and + inline the few needed primitives. Either approach drops the + setimmediate polyfill entirely. + +Documented in 01-12-SUMMARY.md "Known Limitations" section.