repremium/mokosh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(01-08): B+ — vite-plugin-node-polyfills for Buffer (resolves runtime ts-ebml crash)

Browse Source 
Layer 2 of the extended SW-bundle-import gate caught a runtime
ReferenceError: Buffer is not defined at EBMLDecoder.constructor
(this._buffer = Buffer.alloc(0)). Reached from remuxSegments via
extractFramesFromSegment for every input segment — would crash
the SW on every SAVE_ARCHIVE click in real Chrome.

ts-ebml has a 5-year-old open issue (legokichi/ts-ebml#37,
"Can't use Buffer in browser") acknowledging the incompatibility
with no maintainer fix. The canonical Vite workaround is
vite-plugin-node-polyfills with a narrow Buffer-only config (per
the plugin author's official docs).

Changes:
- vite-plugin-node-polyfills@0.27.0 added as devDependency
- vite.config.ts adds nodePolyfills plugin with narrow config:
  include: ['buffer'], globals.Buffer: true, globals.global: false,
  globals.process: false, protocolImports: false (Buffer only, no
  stdlib pull-in)
- bundle delta: SW chunk 373.05 kB (-0.49 kB vs C-config alone);
  +27.48 kB shared polyfill chunk (index-CgqXENQe.js, used by SW
  and offscreen). Net cost ~26.3 kB for full Buffer support.

Bundle verification:
- bundled EBMLDecoder.js now reads `this._buffer = me.alloc(0)`
  where `me` is the imported polyfill Buffer (was `Buffer.alloc(0)`
  against undefined globalThis.Buffer). Same rewrite applied to
  all 3 Buffer.alloc/Buffer.concat/Buffer.from sites in ts-ebml.
- bundle does NOT depend on globalThis.Buffer (the polyfill
  rewrites references as imports, not as global assignments) —
  Layer 1 of the gate still strips Buffer from globalThis and
  passes, confirming this.

Layer 2 gate: RED → GREEN. resolve.alias.ebml fix from commit
52c7636 preserved — still required for ebml CJS-interop;
the polyfill addresses an orthogonal runtime concern.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mark
2026-05-17 12:17:50 +02:00
parent cc6e81a825
commit dd7bf00d1d
3 changed files with 1952 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1941
package-lock.json generated
View File

File diff suppressed because it is too large Load Diff