docs(01-09): Amendment 3 + 01-13 SUMMARY reversal note + STATE.md sync + debug records
Plan 01-09 Amendment 3 (2026-05-19) — atomic documentation pass for the save-does-not-stop-recording charter reversal. Changes: - .planning/phases/01-stabilize-video-pipeline/01-09-PLAN.md: Amendment 3 block added above <success_criteria> (mirrors Amendment 2 placement). Describes the reversed charter, references the new debug record, points at the inverted test file + harness A14. - .planning/phases/01-stabilize-video-pipeline/01-13-SUMMARY.md: "Subsequent Reversal (2026-05-19)" footer added. Notes that npm run test:uat still 15/15 GREEN under the inverted A14 contract; vitest baseline preserved at 98 GREEN. - .planning/STATE.md: Plan 01-13 closure block extended with CHARTER REVERSAL bullet citing the 4 commit SHAs (6ac23fdRED,7645765GREEN,1baaf45A14 invert, this commit docs). - .planning/debug/resolved/01-09-save-stops-recording.md: SUPERSEDED 2026-05-19 footer appended (audit trail; original fix was technically correct against its charter, reversal is UX iteration not technical defect). - .planning/debug/resolved/01-09-save-does-not-stop-recording.md: NEW debug record landed directly in resolved/ (no checkpoint cycle — orchestrator-diagnosed reversal). Documents symptom, charter clarification cycle, fix shape, RED→GREEN evidence with commit SHAs + vitest/harness output, anti-regression coverage at unit + E2E layers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -618,6 +618,31 @@ The harness cannot verify two things, both retained as operator-facing gates:
|
||||
|
||||
The historical 15-step empirical checkpoint (lines 519-548 above) remains in this document as the reference for the original closure intent, and as a fallback if the harness toolchain becomes unavailable (e.g., Puppeteer breakage on a future Chrome major where the harness needs revision).
|
||||
|
||||
## Amendment 3 (2026-05-19) — Save-Does-Not-Stop-Recording (Reverses Save-Stops)
|
||||
|
||||
Per operator UX preference iteration (2026-05-19), the prior save-stops
|
||||
behavior (Amendment 2's harness-PASS-as-closure-gate validated save-stops
|
||||
via A14) is REVERSED. Charter clarified:
|
||||
|
||||
**Recording is continuous; SAVE creates a new zip but does NOT stop the
|
||||
recorder.** The only termination paths are:
|
||||
1. Operator clicks Chrome's "Stop sharing" banner button →
|
||||
user-stopped-sharing path → setIdleMode (Bug B routing preserved)
|
||||
2. Browser closes (SW terminates; offscreen tears down with it)
|
||||
3. Extension uninstalled
|
||||
|
||||
Matches SPEC's "continuous capture / always-on safety net" framing
|
||||
(Тз расширение фаза1.md). Operator workflow: hit bug → save → continues
|
||||
working → next bug also captured.
|
||||
|
||||
Implementation: SAVE_ARCHIVE handler's `finally` block (Amendment 2's
|
||||
STOP_RECORDING + setIdleMode dispatch) REMOVED. See debug session
|
||||
`.planning/debug/resolved/01-09-save-does-not-stop-recording.md`.
|
||||
|
||||
Test inversions lock the new charter: `tests/background/save-archive-does-not-stop-recording.test.ts`
|
||||
(renamed via `git mv` + inverted, history preserved) and Plan 01-13
|
||||
harness A14 (inverted to assert continuous-recording post-SAVE).
|
||||
|
||||
<success_criteria>
|
||||
Plan 01-09 is complete when:
|
||||
1. The 4 displaySurface tests + 13 toolbar/badge/notification/popup-idle-race tests (17 new total) are all GREEN.
|
||||
|
||||
@@ -196,3 +196,13 @@ Remaining Phase 1 gates are operator/designer-facing only:
|
||||
- Plan 01-12 (design integration) — designer reply pending; branded surfaces; will require operator brand-fit ack post-integration
|
||||
|
||||
Phase 2 (DOM + event-capture privacy) inherits the harness as its closure-gate template.
|
||||
|
||||
## Subsequent Reversal (2026-05-19)
|
||||
|
||||
The save-stops-recording fix landed at commit 89f3337 was REVERSED on
|
||||
2026-05-19 per operator UX iteration preferring the original "always-on
|
||||
safety net" charter. See `.planning/debug/resolved/01-09-save-does-not-stop-recording.md`
|
||||
+ Plan 01-09 Amendment 3. Test files inverted to lock the new charter;
|
||||
harness A14 inverted. `npm run test:uat` still 15/15 GREEN under the
|
||||
new contract; vitest baseline preserved at 98 GREEN (the 4 save-archive
|
||||
tests inverted — same count).
|
||||
|
||||
Reference in New Issue
Block a user