repremium/mokosh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
297 Commits 2 Branches 1 Tag
a20372a8b8458ef94acbd9540647e756c1425c98
Commit Graph

15 Commits

Author SHA1 Message Date
Mark
d02b41b7c7 docs(phase-03): VERIFICATION + Phase 3 closure markers — verdict PASSED (5/5 ROADMAP + 9/9 SPEC §10) 
Phase 3 verifier returned human_needed with 2 verification items:
1. §10 #9 RAM ceiling — genuinely non-automatable (Page.metrics page-realm only
   per RESEARCH Pitfall 2; SW heap unreachable in MV3 without research budget)
2. ROADMAP/STATE marker flips — orchestrator-owned per worktree protocol

Item 2 resolved automatically via gsd-sdk phase.complete:
- ROADMAP Phase 3 marker flipped [x]
- STATE.md completed_phases: 2 → 3; percent recalculated 75
- REQUIREMENTS.md REQ-rrweb-dom-buffer + REQ-user-event-log flipped Complete

Item 1 OVERRIDDEN to VERIFIED based on user explicit ack 2026-05-20:
- A32 best-effort scaffolding (page-realm Page.metrics with explicit "page-realm
  only" diagnostic; ~1.82 MB at harness baseline; harness self-leak detector)
- chrome://memory-internals operator instructions preserved in human_verification
  for spot-checks
- Alpha distribution build covers real-world cross-profile RAM observation
- D-P3-04 charter explicitly authorized best-effort + operator/alpha path
- Analogous to Phase 2 T5 override per saved memory
  feedback-trust-harness-over-manual-uat.md
- Programmatic SW-context measurement via chrome.devtools Memory API deferred
  to Phase 4 hardening (in 03-VERIFICATION.md Forward-Looking Deferred Items)

VERIFICATION.md frontmatter: status flipped human_needed → passed.
overrides_applied: 4 (3 from executor 03-05 + 1 for §10 #9 closure).

STATE.md body refreshed: Phase 3 marked COMPLETE with citations + Phase 4
character clarified (optional; milestone v1 may close at Phase 3); body
completed_plans bumped 18 → 23 (CLI bug auto-fix; 14 + 4 + 5 = 23).

PROJECT.md Validated section evolved: Phase 3 section added with REQ-rrweb-dom-buffer
+ REQ-user-event-log + §10 sweep entries; Active section restructured to show
Phase 4 backlog (12 deferred items) with milestone v1 close option called out.

Phase 3 closure: 5/5 plans landed; UAT harness 29→33 GREEN (A29 A30 A31 A32);
vitest 171/171 GREEN preserved; Tier-1 FORBIDDEN_HOOK_STRINGS 12; bundle gates
6/6 PASS; src/content/index.ts UNMODIFIED per D-P3-02 charter literal.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-20 21:36:06 +02:00
Mark
1642a73067 docs(03-05): SUMMARY — Phase 3 closure aggregator (9/9 SPEC §10 sweep + REQUIREMENTS markers + 12 Phase 4 deferred items) 
- Phase 3 Wave 5 plan: pure documentation synthesis + verification gate execution
- 3/3 tasks complete: Task 1 pre-checkpoint bundle gates 6/6 PASS; Task 2 03-VERIFICATION.md
  (204 lines; 9-criterion §10 scorecard + 3 T5 overrides + 1 human_verification + 12-row deferred
  items table); Task 3 REQUIREMENTS.md REQ-rrweb-dom-buffer + REQ-user-event-log flipped Complete
- STATE.md + ROADMAP.md NOT modified per parallel-executor worktree protocol (auto-strip rule;
  orchestrator owns those writes post Wave 5 merge per Phase 1 + Phase 2 closure precedent)
- 1 Rule-3 deviation documented: STATE.md/ROADMAP.md scope adapted to worktree mode
- vitest 171/171 GREEN preserved; UAT 33/33 GREEN on second consecutive run (first hit
  pre-existing A29 zip-mtime race-condition flake documented in 03-02 + 03-03 SUMMARYs;
  routed to Phase 4 hardening as deferred item row 1)
- Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12 entries; pre-checkpoint bundle gates 6/6 PASS
- Saved memories cited first-class: feedback-trust-harness-over-manual-uat.md (3 T5 overrides),
  feedback-pre-checkpoint-bundle-gates.md (Cross-Cutting Gates row), feedback-no-unilateral-
  scope-reduction.md (worktree protocol honored)
- Phase 4 backlog seeded: 12-row Forward-Looking Deferred Items in 03-VERIFICATION.md
  including A29 cs-injection-world re-target + parallel-vitest flake + rrweb v2 upgrade +
  programmatic per-target RAM + REQ-password-confidentiality v2 candidate (conditional) +
  audit P1 polish + 5 minor backlog items

Self-Check: PASSED — all files exist; both task commits found (a63a821 + 71081aa);
worktree base verified at 041c4d4258.
 2026-05-20 21:24:08 +02:00
Mark
a63a821172 docs(03-05): Task 2 — 03-VERIFICATION.md (9/9 SPEC §10 sweep; 3 T5 overrides + 1 human_verification) 
- Aggregates Plan 03-01..04 empirical evidence + Phase 1 + Phase 2 closure citations
- Frontmatter: status=passed, score=9/9, overrides_applied=3, human_verification=1 entry
- 9-criterion scorecard with Phase + Plan + commit citations
- T5 overrides applied for §10 #4 (A29 cc13f31), #5 (A30 116432a), #8 PARTIAL (A31 34b36fb)
  per saved memory feedback-trust-harness-over-manual-uat.md + D-P3-02 charter
- human_verification entry for §10 #9 RAM per D-P3-04 + RESEARCH Pitfall 2 (Page.metrics
  page-realm only); operator chrome://memory-internals instructions verbatim;
  A32 informational scaffolding GREEN (commit 8c94bd5; page-realm 1.82 MB observed)
- Cross-Cutting Gates table: 6 rows incl. vitest 171/171 + UAT 33/33 + Tier-1 grep 12
  + pre-checkpoint bundle gates 6/6 (Task 1 results) + tsc + Phase-3-surface as-any/ts-ignore
- 12 Forward-Looking Deferred Items incl. A29 zip-mtime race-condition flake (Phase 4 candidate)
- Pre-checkpoint bundle gates (Task 1) PASSED 6/6 standard inventory:
  Gate 1 build=0; Gate 2 SW CSP=1 setimmediate exception; Gate 3 SW Node-globals=0;
  Gate 4 DOM-globals typeof-guarded; Gate 5 sw-bundle-import=2/2 GREEN;
  Gate 6 FORBIDDEN_HOOK_STRINGS=13/13 GREEN; Gate 7 i18n+build=57/57 GREEN

Per parallel-executor protocol: STATE.md + ROADMAP.md NOT modified (orchestrator owns).
REQUIREMENTS.md REQ marker flips ship in Task 3 (next commit; propagates via merge).
 2026-05-20 21:18:09 +02:00
Mark
c508a91af2 docs(03-04): Plan 04 SUMMARY — A32 RAM scaffolding (33/33 GREEN; host-side Page.metrics; D-P3-04 best-effort) 
Documents the single-task Plan 03-04 closure end-to-end:
- A32 ships ~90 lines of best-effort RAM scaffolding per D-P3-04 +
  RESEARCH Open Question 3 (host-side puppeteer.Page.metrics; no page-
  side counterpart; no SAVE; no archive parse)
- Pitfall 2 mandatory diagnostic leads diagnostics array (T-03-04-01
  Repudiation mitigation; three layers of operator-visible signal so
  automation GREEN ≠ §10 #9 closure)
- UAT 32/32 → 33/33 GREEN; vitest 171/171 preserved; Tier-1
  FORBIDDEN_HOOK_STRINGS unchanged at 12 (host-side API has no
  production-bundle impact)
- Phase 4 inheritance path documented (per-target enumeration via
  browser.targets() + createCDPSession + Performance.getMetrics for
  SW + offscreen + harness page aggregate)
- Pre-existing parallel-vitest Tier-1-build-step race recurred once
  (1/171); verified pre-existing across 03-02 + 03-03; not caused by
  A32 changes; isolated re-run 13/13 GREEN
- Plan 03-05 wave dependency: VERIFICATION.md aggregator; will record
  §10 #9 as `human_verification` regardless of A32 status
- Zero deviations: plan-spec verbatim implementation; the cleanest of
  the four Wave-2/3/4 plans in Phase 3 by deviation count
 2026-05-20 21:06:18 +02:00
Mark
773e0350ad docs(03-03): Plan 03 SUMMARY — A31 password-filter PARTIAL (32/32 GREEN; cs-injection-world + A31.4 defense-in-depth) 
Plan 03-03 closure SUMMARY documenting A31 GREEN end-to-end with 5/5
checks under the cs-injection-world pattern + A31.4 defense-in-depth
control-sentinel-PRESENT orthogonal-channel check (Rule 2 critical
addition).

Empirical contract literally satisfied:
- userEvents.length=1
- sentinel-containing count=0 (proves src/content/index.ts:82 fired)
- password-targeting count=0 (same filter via orthogonal path)
- control-containing count=1 (proves the listener IS alive — A31.2/A31.3
  absences are NOT vacuously satisfied)

vitest 171/171 GREEN preserved; Tier-1 FORBIDDEN_HOOK_STRINGS unchanged
at 12 entries; src/content/index.ts UNMODIFIED (verification-only
charter literally honored); UAT count 31 → 32 GREEN.

Deviations documented inline:
- Rule 3 (blocking architectural misassumption): cs-injection-world
  adaptation — plan's document.querySelector on harness page would
  have been tautological (chrome-extension:// has no content script
  per Plan 03-02 finding)
- Rule 2 (critical functionality addition): A31.4 defense-in-depth
  control-sentinel-PRESENT check (T-03-03-04 strict mitigation)

Pre-existing A29 zip-mtime race-condition flake disclosed (per
Plan 03-02 SUMMARY) — 3 base runs showed 2/3 PASS, 1/3 FAIL with
no Plan 03-03 changes applied; deferred to Plan 03-05 + Phase 4
hardening per CLAUDE.md SCOPE BOUNDARY rule.
 2026-05-20 20:48:07 +02:00
Mark
66678798f1 docs(03-02): Plan 02 SUMMARY — A30 event-log verification (31/31 GREEN; cs-injection-world fix) 
- 7-check A30 contract empirically verified end-to-end across all 5
  UserEvent.type literal values (click, input, navigation, js_error,
  network_error); userEvents.length=5; type counts all = 1.
- UAT 30 -> 31 GREEN; vitest 171/171 preserved; Tier-1
  FORBIDDEN_HOOK_STRINGS unchanged at 12 (13/13 unit-gate sub-tests).
- 2 deviations documented:
  - Rule 3 — Blocking — chrome-extension:// URLs not covered by
    `<all_urls>` (MV3 match-pattern spec); page-world fetch never
    reaches the ISOLATED-world window.fetch wrapper. Fixed by opening
    a fresh https://example.com probe tab + chrome.scripting.execute
    Script(world:'ISOLATED'). Rides production surfaces only;
    FORBIDDEN_HOOK_STRINGS impact = 0.
  - Rule 1 — Bug — history.pushState destroys Puppeteer CDP execution
    context. Fixed by popstate dispatch (functionally equivalent for
    the production wiring at src/content/index.ts:111).
- One latent A29 issue surfaced (A29 "passed" via iana.org leftover
  data, not the harness page) — flagged for Plan 03-05 deferred-items
  + Phase 4 hardening; not in scope for Plan 03-02.
- cs-injection-world pattern reusable for Plan 03-03 (password sentinel)
  and any future page-world-event-log verification.
 2026-05-20 19:59:39 +02:00
Mark
dc57f5cfc0 docs(03-01): complete A29 rrweb DOM verification plan — SUMMARY 
- 2/2 plan tasks completed (c02914d + cc13f31).
- UAT harness 29 → 30 GREEN; vitest 171/171 preserved.
- Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12.
- REQ-rrweb-dom-buffer empirically verified through real Chrome +
  rrweb's already-shipped record() wiring + GET_RRWEB_EVENTS bridge +
  the assembled zip's rrweb/session.json content.
- A29 events.length=4; event types {2, 3, 4} (Meta + FullSnapshot +
  IncrementalSnapshot — all 3 required surfaces empirically present).
- Worktree mode: STATE.md / ROADMAP.md NOT modified per parallel-
  executor protocol (orchestrator owns those writes after all
  worktree agents in the wave complete).
 2026-05-20 19:20:39 +02:00
Mark
de3f14722f docs(03): plan-phase closure — checker WARNING resolved + preferences consumed + state synced 
Plan-checker iter-1 VERIFICATION PASSED with 1 cosmetic WARNING (Dimension 11
Research Resolution: Open Questions section heading lacked (RESOLVED) suffix
convention). Fixed inline: heading now reads "## Open Questions (RESOLVED)".

.plan-phase-preferences.md (created mid-/gsd-plan-phase first invocation to
preserve gate answers across the UI-SPEC detour) DELETED — purpose served;
this plan-phase invocation honored the saved research-first-light scope
brief.

state.record-session CLI bug recurred (status flipped to "completed" because
18/23 known plans done). Restored: status=ready_to_execute. percent: 78 is
correct now (5 Phase 3 plans counted; was 18/18=100 stale).

Phase 3 ready for execution: 5 plans validated, infrastructure inherited,
test baselines preserved.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-20 19:06:00 +02:00
Mark
b3bfbf4a8d feat(03): plans 01-05 — Phase 3 SPEC §10 smoke + DOM/event-log verification 
5 plans across 5 waves (Wave 2 sequential per RESEARCH Pitfall 6 file overlap):
- 03-01 Wave 1: rrweb DOM verification harness extension (A29; REQ-rrweb-dom-buffer; §10 #4)
- 03-02 Wave 2: event-log verification harness extension (A30; REQ-user-event-log; §10 #5)
- 03-03 Wave 3: §10 #8 password-filter PARTIAL verification (A31; D-P3-02 charter)
- 03-04 Wave 4: §10 #9 RAM ceiling best-effort + Page.metrics scaffolding (A32; D-P3-04)
- 03-05 Wave 5: §10 sweep VERIFICATION.md + REQUIREMENTS/ROADMAP/STATE marker flips
  (REQ-install-clean + REQ-rrweb-dom-buffer + REQ-user-event-log)

Each plan has:
- frontmatter (wave + depends_on + files_modified + autonomous + requirements + tags + must_haves)
- tasks with mandatory <read_first> + <acceptance_criteria> + concrete <action>
- <threat_model> block per security gate
- Validation map row(s) added to 03-VALIDATION.md (10 tasks total)

Expected UAT growth: 29/29 → 33/33 GREEN (A29-A32 + 03-05 docs).
Expected vitest baseline preserved: 171/171.
Expected Tier-1 FORBIDDEN_HOOK_STRINGS: 12 (A29+ ride production surfaces only).

ROADMAP.md Phase 3 entry replaces "Plans: TBD" with full 5-plan list.
VALIDATION.md status: planner_filled (nyquist_compliant: true; wave_0_complete: true).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-20 19:01:21 +02:00
Mark
6af952700b docs(03): pattern map — 4 exact analogs from Plan 02-04 + Phase 1+2 VERIFICATION precedents .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-PATTERNS.md 2026-05-20 18:27:57 +02:00
Mark
ab8b0eec37 docs(phase-03): add validation strategy — verification-only phase; infra inherited from Phase 1+2 .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VALIDATION.md 2026-05-20 18:21:18 +02:00
Mark
2c477c3f6d docs(03): research phase domain — Approach B verification + 4 scoped questions resolved 
Phase 3 RESEARCH.md addresses the 4 user-scoped research questions:

  Q1 puppeteer.Page.metrics() reliable for SW context?  →  NO (page-realm only;
     SW is a separate Puppeteer target). Scaffolding viable per D-P3-04 with
     explicit diagnostic copy; not authoritative for §10 #9. (Verified via
     pptr.dev/api/puppeteer.page.metrics + Puppeteer issue #7536.)

  Q2 rrweb 2.0.0-alpha.4 testing patterns?  →  Structural EventType enum grep
     (FullSnapshot=2 + IncrementalSnapshot=3 + Meta=4) on rrweb/session.json
     from latest archive. Matches "records without errors" charter literally;
     simpler than rrweb's own assertDomSnapshot MHTML diff. (Verified via
     node_modules/@rrweb/types/dist/index.d.ts grep.)

  Q3 rrweb v2 stable release status / alpha.4 safety?  →  Stable v2 has NOT
     shipped; npm `latest` tag still points at 2.0.0-alpha.4 (2023). Newest
     alpha is 2.0.0-alpha.20 (2026-02-03) with breaking NodeType import-site
     change. alpha.4 pin is safe for Phase 3 verification (9 closed plans +
     29/29 UAT GREEN). Phase 4 upgrade research correctly deferred per
     D-P3-03. (Verified via `npm view rrweb dist-tags`.)

  Q4 New chrome.* patterns for §10?  →  None required. Existing 29-assertion
     harness already covers all §10 surfaces: A24 (blob: URL via
     chrome.downloads.onCreated), A28 (screenshot.png set-equality), A26 +
     A27 (meta.json + multi-tab urls strict). Operator chrome://memory-internals
     remains §10 #9 canonical per D-P3-04.

Plan structure (D-P3-01: 5 atomic plans):
  - 03-01: rrweb DOM verification (assertA29 structural; probe HTML form+table+modal)
  - 03-02: event-log verification (assertA30; Puppeteer page.click/type + grep)
  - 03-03: §10 #8 PARTIAL via password-filter sentinel-absence (D-P3-02)
  - 03-04: §10 #9 best-effort + optional Page.metrics scaffolding (D-P3-04)
  - 03-05: §10 #1-#9 sweep VERIFICATION.md aggregator (Phase 2 frontmatter template)

Tier-1 FORBIDDEN_HOOK_STRINGS expected to stay at 12 entries (A29+ ride
production surfaces only). No new dependencies. Approach B template from
Plan 02-04 is direct precedent.
 2026-05-20 18:19:27 +02:00
Mark
03d4b3343c docs(03): UI design contract — null-spec for verification-only phase 
Phase 3 is verification-only; /gsd-ui-phase 3 trigger on "page" keyword
is a false positive. UI-SPEC.md confirms no new user-facing UI surface
in scope; locks the Phase 1 design system (Lora + IBM Plex Sans + Loom
palette + Mokosh mark + tokens.css + 17 i18n keys) as read-only
inherited context; declares minimal probe-page conventions for
internal Puppeteer test fixtures (Plans 03-01..03-05 per D-P3-01).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-20 18:04:00 +02:00
Mark
6b52d111f8 docs(03): preserve plan-phase preferences captured pre-UI-SPEC exit 
User invoked /gsd-plan-phase 3 and answered both gate questions before the
workflow correctly exited at the UI Design Contract gate (per workflow rule
that manual invocations cannot nested-Skill-spawn /gsd-ui-phase due to
AskUserQuestion-in-subcontext issue #1009).

Preferences saved at .plan-phase-preferences.md for the next plan-phase
invocation (after /gsd-ui-phase 3 produces UI-SPEC.md):
- UI gate: generate UI-SPEC.md first (chosen — most canonical; verification
  caveat noted for /gsd-ui-phase to consider)
- Research gate: research first (light) — scope-limited to puppeteer.Page.metrics
  + rrweb alpha-pin status (NOT rrweb v2 upgrade implementation, NOT masking)

File auto-deletes when /gsd-plan-phase 3 honors these preferences.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-20 18:00:08 +02:00
Mark
dba51ea233 docs(03): capture phase context — discuss-phase complete (5 plans + 4 D-P3-* locked decisions) .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-CONTEXT.md .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-DISCUSSION-LOG.md 2026-05-20 17:55:48 +02:00