Mark
526ac78046
Wave structure: - W1 (parallel): 04-01 (Audit P1 polish #11/#14/#15 TDD) + 04-02 (build/CSP hygiene: setimmediate polyfill + dead-code + generate-icons.cjs) - W2: 04-03 (A29 cs-injection-world rewrite; closes flake) - W3: 04-04 (A33 SW state persistence; spike-first + CDP worker.close()) - W4: 04-05 (A34 fetch+XHR network_error; ROADMAP SC #2 + validates Plan 04-01 P1 #11 end-to-end) - W5: 04-06 (dark-logo currentColor + cursor verification + 01-07-SUMMARY back-patch; operator empirical) - W6: 04-07 (04-VERIFICATION.md aggregator + ROADMAP backfill + v1 close prep) Honors locked decisions D-P4-01..05 (full Phase 4 + all 3 P1 polish + both visual items + alpha-independent + ROADMAP backfill). Implements RESEARCH Q1 (setimmediate option a), Q2 (spike-first SW persistence), Q3 (A29 cs-injection-world), Finding 4 (cursor already shipped — verification only). UI-SPEC dark-logo currentColor strategy with inline-SVG injection landed per UI-SPEC §"Implementation amendment". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
26 KiB
26 KiB
phase, slug, plan, type, wave, depends_on, files_modified, autonomous, requirements, tags, user_setup, must_haves
| phase | slug | plan | type | wave | depends_on | files_modified | autonomous | requirements | tags | user_setup | must_haves | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 04 | harden-clean-up-optional | 07 | execute | 6 |
|
|
true |
|
|
Three workstreams:
-
04-VERIFICATION.md (NEW; aggregator): Create the canonical Phase 4 verification document per the precedents at Phase 3 03-VERIFICATION.md + Phase 2 02-VERIFICATION.md + Phase 1 01-VERIFICATION.md. The 4 ROADMAP SCs are cited row-by-row with evidence (Plan + commit ref + UAT assertion ID + grep gate output). The audit P1 polish items (#11 + #14 + #15) and the additional Phase 4 work (setimmediate polyfill + dead-code grep + generate-icons rename + A29 race fix + cursor verification + dark-logo strategy) are inventoried in a non-ROADMAP-SC section as "Audit residual closure" with the same evidence shape. Cross-cutting gates section: UAT harness 33 -> 35 GREEN (+A33 from Plan 04-04 + A34 from Plan 04-05), vitest baseline 171 -> >=185 GREEN, Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12, pre-checkpoint bundle gates 6/6 PASS (Gate 2 polarity flipped 1 -> 0 per Plan 04-02). Operator empirical ack (Plan 04-06 Task 4) cited verbatim. Deferred Items table carries forward the v1.1/v2 items from CONTEXT.
-
ROADMAP backfill (D-P4-05): Per the plan-checker flag #4 against Plan 01-13 — Plans 01-08..01-13 were inline-tracked but not row-added in ROADMAP.md Phase 1 row block. PATTERNS.md notes the rows ARE at lines 90-95 already, so this is mostly a verification + addition of any missing row text per re-audit. Add any Phase 2/3 plan rows similarly missing (per the re-audit; per saved feedback
feedback-no-unilateral-scope-reduction.md, surface every potentially-missing row to the user via the VERIFICATION.md backfill table for sign-off rather than pre-filtering). -
Marker flips: REQUIREMENTS.md (no new REQs but optional closure notes); ROADMAP.md (Phase 4 row [x] with date); STATE.md (
progress.completed_phases: 4;current_focus: v1 milestone CLOSED-PENDING-ALPHA OR CLOSED); PROJECT.md (Validated section evolves; DEC-* table closure citations where applicable).
Purpose: Closes Phase 4 + closes v1 milestone (or stages CLOSED-PENDING-ALPHA gate depending on alpha redistribution state per D-P4-04). Phase 4 is THE LAST phase per the 4-phase ROADMAP; no Phase 5 work is planned.
Output: 1 NEW VERIFICATION.md + 4 docs marker flips. No code, no tests, no harness changes. Single closure commit per file (or 1 mega-commit per the closure convention).
<execution_context> @$HOME/.claude/get-shit-done/workflows/execute-plan.md @$HOME/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/REQUIREMENTS.md @.planning/phases/04-harden-clean-up-optional/04-CONTEXT.md @.planning/phases/04-harden-clean-up-optional/04-RESEARCH.md @.planning/phases/04-harden-clean-up-optional/04-PATTERNS.md @.planning/phases/04-harden-clean-up-optional/04-UI-SPEC.md @.planning/phases/04-harden-clean-up-optional/04-VALIDATION.mdPrior verification documents — pattern precedents
@.planning/phases/01-stabilize-video-pipeline/01-VERIFICATION.md @.planning/phases/02-stabilize-export-pipeline/02-VERIFICATION.md @.planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VERIFICATION.md
Plan SUMMARYs for evidence rows (populated when Plans 04-01..04-06 complete; this plan executes last)
@.planning/phases/04-harden-clean-up-optional/04-01-SUMMARY.md (Plan 04-01 closure)
@.planning/phases/04-harden-clean-up-optional/04-02-SUMMARY.md (Plan 04-02 closure)
@.planning/phases/04-harden-clean-up-optional/04-03-SUMMARY.md (Plan 04-03 closure)
@.planning/phases/04-harden-clean-up-optional/04-04-SUMMARY.md (Plan 04-04 closure)
@.planning/phases/04-harden-clean-up-optional/04-05-SUMMARY.md (Plan 04-05 closure)
@.planning/phases/04-harden-clean-up-optional/04-06-SUMMARY.md (Plan 04-06 closure)
From .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VERIFICATION.md (immediate prior precedent; 4-override template):
- Frontmatter shape:
phase+verifiedISO timestamp +status: passed+score: <N>/<N> ROADMAP success criteria + <M>/<M> SPEC §10 criteria+overrides_applied: <count>+re_verificationblock +override_notesblock +human_verificationblock +deferredblock. - Body sections: Per-Requirement Scorecard + Cross-Cutting Gates + Operator-Empirical Acks (verbatim + commit refs) + Deferred Items.
From .planning/phases/01-stabilize-video-pipeline/01-VERIFICATION.md (per-requirement scorecard + cross-cutting gates + operator acks shape):
- Per-Requirement Scorecard: one row per REQ, columns include {ID, Acceptance, Status, Evidence, Plan + commit}.
- Cross-Cutting Gates: vitest count, UAT count, Tier-1 grep count, bundle gates 6/6.
- Operator-Empirical Acks: verbatim quote + date + commit + context (the operator surface that was empirically validated).
- Deferred Items: forward-looking table with category + item + status + deferred_at.
Per CONTEXT §"Deferred Ideas" — v1.1/v2 items to carry forward in 04-VERIFICATION.md:
- rrweb 2.0.0-alpha.4 -> stable v2 upgrade (D-P3-03 + D-P4-01)
- Programmatic SW-realm RAM measurement (D-P3-04 + D-P4-01)
- REQ-password-confidentiality v2 candidate (D-P3-02; only if charter reverses)
- Alpha-tester findings integration (D-P4-04; routed via separate maintenance window)
Frontmatter sketch for 04-VERIFICATION.md:
# (yaml document marker omitted for parser-compat)
phase: 04-harden-clean-up-optional
verified: 2026-05-21T<HH-MM-SS>Z
status: passed
score: 4/4 ROADMAP success criteria + 3/3 audit P1 polish items + 5/5 hardening items (setimmediate + dead-code + generate-icons + A29 race + cursor verify + dark-logo)
overrides_applied: <count>
re_verification:
milestone: v1.0.0
previous_phase_status: 3/3 phases complete
previous_phase_score: 5/5 SPEC §10 + 9/9 acceptance criteria with 4 overrides
gaps_closed:
- "ROADMAP SC #1 — SW state persistence via A33 harness assertion (Plan 04-04)"
- "ROADMAP SC #2 — fetch + XHR network_error via A34 harness assertion (Plan 04-05) + P1 #11 unit tests (Plan 04-01)"
- "ROADMAP SC #3 — generate-icons.cjs rename verified (Plan 04-02)"
- "ROADMAP SC #4 — dead-code grep regression-pinned (Plan 04-02)"
- "Audit P1 #11/#14/#15 — content-script polish tests GREEN (Plan 04-01)"
- "setimmediate polyfill — dist/ SW chunk grep 0 hits 'new Function' (Plan 04-02)"
- "A29 flake — strict-sentinel rewrite + 5/5 PASS stress (Plan 04-03)"
- "Cursor visibility — verified shipped at recorder.ts:285 + 01-07-SUMMARY back-patched (Plan 04-06; RESEARCH Finding 4)"
- "Dark-logo currentColor strategy — inline-SVG injection landed (Plan 04-06; operator ack received)"
- "ROADMAP backfill Plans 01-08..01-13 — verified per D-P4-05 (this plan)"
override_notes:
- dimension: "<per-criterion override per Phase 4 needs>"
initial_status: "<...>"
override_to: "<...>"
rationale: |
<verbatim memory-citation block>
human_verification:
- test: "dark-mode operator visual aesthetic on welcome hero"
expected: "mark legible on OS dark-mode rendering surface"
why_human: "Aesthetic contrast judgment — UI-SPEC §'Manual-Only Verifications' acceptance criterion #6; canonical operator-empirical case per feedback-trust-harness-over-manual-uat.md"
evidence: "Plan 04-06 Task 4 operator ack <verbatim>"
deferred:
- truth: "rrweb 2.0.0-alpha.4 -> stable v2 upgrade"
addressed_in: "v1.1 / v2 maintenance milestone"
evidence: "D-P3-03 + D-P4-01 charter exclusion + alpha-pin stable across 13 plans + 35/35 UAT GREEN"
- truth: "Programmatic SW-realm RAM measurement via chrome.devtools Memory API"
addressed_in: "v1.1 / v2 maintenance milestone"
evidence: "D-P3-04 + D-P4-01 charter exclusion; A32 best-effort + chrome://memory-internals + alpha-distribution coverage accepted"
- truth: "REQ-password-confidentiality v2 candidate"
addressed_in: "v1.1 / v2 maintenance milestone IF charter reverses"
evidence: "D-P3-02 + D-P4-01 charter exclusion 2026-05-20 — 'we don't care about privacy hardening'"
- truth: "Alpha-tester findings integration"
addressed_in: "post-v1 maintenance window"
evidence: "D-P4-04 charter — operator handles alpha signal out-of-band"
# (yaml document marker omitted for parser-compat)
2. Create `.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md` with frontmatter per the sketch in `<interfaces>` above. Replace placeholder fields with actual values from the Plan 04-01..04-06 SUMMARYs:
- `verified:` — current ISO timestamp (`date -u +%Y-%m-%dT%H:%M:%SZ`)
- `score:` — fill in actual counts from SUMMARYs
- `re_verification.gaps_closed[*]` — bullet per closed gap with Plan + commit citation
- `override_notes` — populate if any T5 override applied to a Phase 4 criterion (e.g., the operator-empirical UAT for dark-logo can be cited as harness-coverage-augmented rather than override; depends on Plan 04-06 outcome).
- `human_verification[0].evidence` — verbatim operator ack quote from Plan 04-06 Task 4 SUMMARY.
- `deferred[]` — 4 v1.1/v2 items per CONTEXT Deferred Ideas + the alpha-distribution item per D-P4-04.
3. Body sections (after frontmatter):
- `## Per-Requirement Scorecard` — Phase 4 has no new REQs but rows for the 4 ROADMAP SCs + the 5 hardening items (per `score:` line). Each row: {Item, Acceptance, Status, Evidence, Plan + commit}.
- `## Cross-Cutting Gates`:
- vitest count: 171 (Phase 3 baseline) -> 171 + new Wave 0 tests from Plans 04-01 + 04-02 + 04-06 = approximately 171 + 8 + 2 + 4 = 185 GREEN (verify exact count via final `npm test -- --run` invocation).
- UAT harness count: 33 -> 35 GREEN (Plans 04-04 A33 + 04-05 A34 added; Plan 04-03 rewrote A29 in-place, count unchanged).
- Tier-1 FORBIDDEN_HOOK_STRINGS: 12 unchanged (Phase 4 introduced no new __MOKOSH_UAT__-gated symbols per CONTEXT Claude's Discretion).
- Pre-checkpoint bundle gates: 6/6 PASS (Plan 04-02 flipped Gate 2 polarity 1 -> 0 hits `new Function`).
- `## Operator-Empirical Acks (verbatim + commit refs)`:
- Append the Plan 04-06 Task 4 ack from the SUMMARY (verbatim quote + date + commit hash).
- `## Deferred Items` — table mirroring frontmatter `deferred:`.
- `## ROADMAP backfill verification (D-P4-05)` — list of Plans 01-08..01-13 row presence + any newly-added rows. If all rows are already present (per PATTERNS.md noting lines 90-95 exist), this section's content is "Verified — no row additions needed; plan-checker flag #4 closed".
4. Commit: `docs(04-07): Phase 4 closure — 04-VERIFICATION.md aggregator (4/4 ROADMAP SCs + N/N hardening items)`.
Edit 2 — ROADMAP.md (Phase 4 row [x] + backfill verification):
- Locate the Phase 4 entry under `## Phases` (top-level list). Flip `- [ ] **Phase 4: Harden + clean up** _(optional)_ ...` to `- [x] **Phase 4: Harden + clean up** _(optional)_ — CLOSED 2026-05-21 via Plan 04-07 closure (4/4 ROADMAP SCs + N/N hardening items GREEN; 04-VERIFICATION.md at .planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md). UAT 33 -> 35 GREEN; vitest 171 -> >=185 GREEN; Pre-checkpoint bundle gates 6/6 PASS (Gate 2 polarity flipped per Plan 04-02). Operator empirical ack 2026-05-21 (Plan 04-06) for dark-mode visual aesthetic.`
- Locate the Phase 4 details section. Add `**Plans**:` list with rows for 04-01..04-07 (mirror Phase 3 plan-row block):
- [x] 04-01-PLAN.md — Audit P1 polish #11 + #14 + #15 (TDD; 3 unit tests + 3 surgical edits in src/content/index.ts)
- [x] 04-02-PLAN.md — Build/CSP hygiene (setimmediate polyfill + dead-code grep + generate-icons.cjs rename)
- [x] 04-03-PLAN.md — A29 cs-injection-world rewrite (strict-sentinel; 5/5 PASS stress)
- [x] 04-04-PLAN.md — A33 SW state persistence harness assertion (5-min idle + worker.close() CDP; ROADMAP SC #1)
- [x] 04-05-PLAN.md — A34 fetch + XHR network_error empirical (ROADMAP SC #2; validates Plan 04-01 P1 #11 end-to-end)
- [x] 04-06-PLAN.md — Dark-logo currentColor + cursor visibility verification + 01-07-SUMMARY back-patch (UI-SPEC; operator empirical ack)
- [x] 04-07-PLAN.md — Phase 4 closure aggregator (this plan)
- Update the `## Progress` table row for Phase 4: change `0/TBD` to `7/7` and set Status to CLOSED 2026-05-21.
- Verify Plans 01-08..01-13 rows exist in the Phase 1 plan-row block (per D-P4-05). Per PATTERNS.md they ARE at lines 90-95; just verify visually + document in 04-VERIFICATION.md.
Edit 3 — STATE.md (frontmatter + Current Position + Session Continuity):
- Frontmatter:
- `progress.completed_phases: 4` (was 3).
- `progress.total_plans: 30` (was 23; +7 from Phase 4) — verify the exact count.
- `progress.completed_plans: 30` (was 23; +7).
- `progress.percent: 100`.
- `status: ready_for_v1_close` OR `status: v1_closed` depending on whether the v1 close is a separate ceremony.
- `stopped_at: 'Phase 4 closed 2026-05-21; v1 milestone ready for alpha re-distribution (per D-P4-04 ack out-of-band)'`.
- `last_updated:` — current ISO timestamp.
- Current Position block: update narrative to reflect Phase 4 closure + milestone v1 close gate (alpha redistribution).
- Performance Metrics section: append Phase 04 row to the "By Phase" table with the plan count + cumulative time.
- Session Continuity log: prepend a new entry for the current session "2026-05-21 Phase 4 closed end-to-end via 7 plans (04-01..04-07); v1 milestone ready for alpha redistribution".
Edit 4 — PROJECT.md (Validated section + DEC closure citations):
- Locate the `## Validated` section. Append a Phase 4 entry summarizing the hardening + audit-residual closure + visual polish.
- DEC-* table: if any DEC was touched by Phase 4 plans (likely none — Phase 4 is hardening, not new decisions), append closure citations. Otherwise no change.
- Active section: update Phase 4 status to CLOSED; remove from active backlog.
Verify gates:
- `git status` — only the 4 docs + 1 new VERIFICATION.md are dirty (no inadvertent code changes).
- Each edit lands as a separate atomic commit OR one combined closure commit per the closure convention (Phase 1 + 2 + 3 precedent used 1 commit per marker file; Phase 4 should mirror).
<threat_model>
Trust Boundaries
| Boundary | Description |
|---|---|
| Phase 4 plan SUMMARYs -> 04-VERIFICATION.md aggregator | aggregator reads each SUMMARY's reported counts + commit refs verbatim; no fabrication; if a SUMMARY is missing or incomplete, the aggregator MUST flag rather than fill defaults |
| 04-VERIFICATION.md -> alpha redistribution -> tester confirmation | The 04-VERIFICATION.md scorecard is what the operator references when deciding whether the v1 build is ready for alpha tester redistribution per D-P4-04; misleading scorecard rows could cause premature alpha-build sign-off |
STRIDE Threat Register
| Threat ID | Category | Component | Disposition | Mitigation Plan |
|---|---|---|---|---|
| T-04-07-01 | Repudiation | aggregator could over-claim closure (e.g., mark ROADMAP SC #2 GREEN when only fetch is empirically verified but XHR is not) | mitigate | Each scorecard row MUST cite specific UAT assertion ID (e.g., "A34.3 XHR 404 -> network_error" or "A34.5 XHR meta.status === 404") + commit hash; absence of an assertion = row marked PARTIAL or YELLOW with explanation |
| T-04-07-02 | Tampering | a docs-only commit could in theory be conflated with a code commit; the closure ceremony must be docs-pure | accept | Verification gate git diff --stat HEAD~1 HEAD on closure commits should show only .planning/ files dirty; pre-commit check |
| T-04-07-03 | Repudiation | alpha redistribution decision is non-automated (per D-P4-04 user handles out-of-band); 04-VERIFICATION.md is advisory not gating | accept | Documented in scorecard + STATE.md status field clarifies v1 close vs CLOSED-PENDING-ALPHA distinction |
| </threat_model> |
<success_criteria>
- 04-VERIFICATION.md aggregator created (Task 1).
- 4 marker files updated for Phase 4 closure (Task 2).
- Plans 01-08..01-13 ROADMAP backfill verified (D-P4-05).
- v1 milestone status updated: CLOSED-PENDING-ALPHA OR CLOSED.
- All Phase 4 success criteria from the ROADMAP cited as GREEN with evidence.
- Operator empirical ack from Plan 04-06 cited verbatim in 04-VERIFICATION.md.
- Deferred items table carries forward v1.1/v2 items per CONTEXT.
- No code/test changes (docs-only ceremony). </success_criteria>