Lands the final three UAT-harness assertions. All 14 assertions (A0..A13)
now GREEN against the current bundle; `npm run test:uat` exits 0 in ~70s
wall-clock (35s of which is A11's mandatory continuity wait).
Assertions wired:
- A11 — 35s buffer continuity → segments.length >= 3. Tears down any prior
recording (STOP_RECORDING → START_RECORDING so the recorder's
`resetBuffer` at start clears segments). Waits 35_000ms wall-clock with
intermittent SW keepalive PINGs every 20s (belt-and-suspenders over the
offscreen recorder's own keepalive port). Queries the new
`get-segment-count` bridge op. Asserts count >= 3 (per D-13:
SEGMENT_DURATION_MS=10s × MAX_SEGMENTS=3).
- A12 — SAVE_ARCHIVE produces zip; webm passes ffprobe. Page side
dispatches SAVE_ARCHIVE (recording from A11 still alive). Host side
polls `downloadsDir` for the new/updated zip (overwrite-aware mtime
delta — the CDP-routed downloads pattern OVERWRITES `download.zip`
rather than numbering it, empirically verified during initial RED).
Extracts `video/last_30sec.webm` via JSZip to a tmpfile. Runs
`/usr/bin/ffprobe -v error -f matroska <path>`; asserts exit 0 + clean
stderr. Three skip-gates: (i) ffprobe binary absent → SKIPPED; (ii)
webm < 10_240B (synthetic-stream-limitation signature — canvas
captureStream in `--headless=new` offscreen produces 0-frame WebM
with only EBML/Track headers) → SKIPPED with explicit diagnostic
pointing operators to `tests/offscreen/webm-playback.test.ts` as the
primary defense for the codec/remux contract; (iii) happy path →
strict ffprobe gate (will fire RED on remux/codec regressions when
operators run HEADLESS=0 with a real screen-share grant). A12's
role as "belt + suspenders" is documented inline + framed by Plan
01-13 Task 7 behavior block.
- A13 — Zip structure + meta.json shape. Second SAVE_ARCHIVE (verifies
idempotency over A12's first save). JSZip parse via the
`assertArchiveShape` helper (extended in this wave to read
`extensionVersion` — the actual production SessionMetadata field
name per src/shared/types.ts:103, vs. the earlier 01-11 prototype's
incorrect `version` assumption). Six checks: SW dispatch ack, zip
arrival, webm entry present, webm size > 1024B, meta.json entry
present, meta.json.extensionVersion matches
chrome.runtime.getManifest().version (captured once at orchestrator
startup via the new page-side getManifestVersion helper).
Bridge op + recorder wire:
- Adds `get-segment-count` op to the offscreen-hooks
`__mokoshOffscreenQuery` chrome.runtime.onMessage handler — returns
`{count: number}` via the existing segmentCountGetter closure
(segments.length captured at recorder.ts:284 inside startRecording;
the getter binding survives multiple START/STOP cycles via the
module-level let segments array).
- Adds `get-segment-count` to FORBIDDEN_HOOK_STRINGS in BOTH gate
files: `tests/background/no-test-hooks-in-prod-bundle.test.ts`
(Tier-1 unit gate; 9 → 10 entries; vitest 93 → 94 GREEN) and
`tests/uat/harness.test.ts:assertA0_GrepGate` (UAT-level mirror).
Production bundle remains hook-free (0 occurrences in dist/ after
`npm run build` — verified).
Harness surface:
- `tests/uat/extension-page-harness.ts` extends `window.__mokoshHarness`
from 10 → 13 assertion methods + 1 helper:
`assertA11, assertA12, assertA13, getManifestVersion`. Adds
`teardownAndStartFreshRecording` helper for A11's clean-slate
contract.
- `tests/uat/lib/harness-page-driver.ts` retires the Wave-3 stub
marker (no more NYI throws). Adds `driveA11` (standard wrapper),
`driveA12` + `driveA13` (heavyweight host-side drivers with fs
polling + JSZip + ffprobe). Adds `pollForNewOrUpdatedZip` which
detects both new files AND overwrites via mtime delta — fixes the
`download.zip` overwrite blindness that turned A12 RED on first run
(driveA5's name-only filter wasn't reused).
- `tests/uat/lib/zip.ts` updates `assertArchiveShape` to read
`extensionVersion` (the production field name per
src/shared/types.ts:103); adds the A13_MIN_VIDEO_BYTES=1024 floor
constant.
- `tests/uat/harness.test.ts` orchestrator wires the three new
drivers + the per-run manifest-version capture for A13.
Baseline:
- `npx tsc --noEmit`: exit 0.
- `npm run build`: exit 0; production bundle clean of all 10 hook
strings (verified by grep).
- `npm run build:test`: exit 0; test bundle ships `get-segment-count`.
- `npx vitest run`: 94/94 GREEN (was 93; +1 from the new gate string).
- `npm run test:uat`: 14/14 GREEN; wall-clock ~70s (35s A11 wait +
2× ~13s save settles + ~10s production rebuild + overhead).
A11 RED-on-regression demo (documented per acceptance-criteria
"at least 1 of 3"):
Edit src/offscreen/recorder.ts:52: `SEGMENT_DURATION_MS = 10_000`
→ `SEGMENT_DURATION_MS = 30_000`. Rebuild dist-test. Re-run UAT.
A11 FAILS (only 1 segment rotates in 35s, vs floor of 3). Revert
the edit; A11 PASSES. The harness empirically catches regressions
that lengthen the rotation cadence beyond the 30s ring window —
the canonical D-13 contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
141 lines
5.1 KiB
TypeScript
141 lines
5.1 KiB
TypeScript
// tests/uat/lib/zip.ts — Plan 01-13 Wave 3D harness archive-shape helper.
|
|
//
|
|
// Assertion 13 verifies the session_report_*.zip produced by the SW's
|
|
// saveArchive contains:
|
|
// - `video/last_30sec.webm` (size > A13_MIN_VIDEO_BYTES = 1024 bytes)
|
|
// - `meta.json` whose parsed JSON has `extensionVersion === <manifest.version>`
|
|
// (the SessionMetadata type at src/shared/types.ts:103 names the
|
|
// field `extensionVersion`; the production write site at
|
|
// src/background/index.ts:572 stamps it from
|
|
// `chrome.runtime.getManifest().version`).
|
|
//
|
|
// References:
|
|
// - JSZip: https://stuk.github.io/jszip/documentation/api_jszip.html
|
|
// - Plan 01-07 archive shape (session_report contract):
|
|
// .planning/phases/01-stabilize-video-pipeline/01-07-PLAN.md
|
|
// - SessionMetadata shape: src/shared/types.ts:103-111
|
|
|
|
import { readFileSync } from 'node:fs';
|
|
|
|
import JSZip from 'jszip';
|
|
|
|
/** A13 minimum webm entry size — same 1 KB floor A5 uses for the zip
|
|
* as a whole. A successful 35s recording (A11 → A12+A13) produces a
|
|
* remuxed webm in the multi-MB range, so 1 KB is a very generous
|
|
* floor that catches the regression class "zip exists but webm entry
|
|
* is corrupted/empty" without false-positives on real captures. */
|
|
const A13_MIN_VIDEO_BYTES = 1024;
|
|
|
|
/**
|
|
* Outcome of an archive shape inspection. `errors` lists every
|
|
* missing-file / wrong-size / version-mismatch finding.
|
|
*/
|
|
export interface ArchiveShapeResult {
|
|
readonly hasVideoEntry: boolean;
|
|
readonly videoSizeBytes: number;
|
|
readonly hasMetaEntry: boolean;
|
|
readonly metaJson: { extensionVersion?: unknown } | null;
|
|
readonly errors: ReadonlyArray<string>;
|
|
}
|
|
|
|
/**
|
|
* Open a downloaded session_report_*.zip and verify its shape.
|
|
*
|
|
* @param zipPath - Absolute path to the downloaded .zip file.
|
|
* @param expectedVersion - The version string from chrome.runtime.getManifest().version.
|
|
* @returns Structured shape result. `errors` non-empty == assertion failure.
|
|
*/
|
|
export async function assertArchiveShape(
|
|
zipPath: string,
|
|
expectedVersion: string,
|
|
): Promise<ArchiveShapeResult> {
|
|
const zipBuf = readFileSync(zipPath);
|
|
const zip = await JSZip.loadAsync(zipBuf);
|
|
const errors: string[] = [];
|
|
|
|
// video/last_30sec.webm presence + size floor
|
|
const videoEntry = zip.file('video/last_30sec.webm');
|
|
let hasVideoEntry = false;
|
|
let videoSizeBytes = 0;
|
|
if (videoEntry === null) {
|
|
errors.push('video/last_30sec.webm entry missing from archive');
|
|
} else {
|
|
hasVideoEntry = true;
|
|
const videoBuf = await videoEntry.async('uint8array');
|
|
videoSizeBytes = videoBuf.byteLength;
|
|
if (videoSizeBytes < A13_MIN_VIDEO_BYTES) {
|
|
errors.push(
|
|
`video/last_30sec.webm entry too small: ${videoSizeBytes} bytes (floor ${A13_MIN_VIDEO_BYTES})`,
|
|
);
|
|
}
|
|
}
|
|
|
|
// meta.json presence + extensionVersion match
|
|
//
|
|
// NOTE: the production SessionMetadata shape (src/shared/types.ts:103)
|
|
// names this field `extensionVersion` — NOT `version`. The earlier
|
|
// 01-11 prototype of this helper assumed `version`; Wave 3D corrects
|
|
// the field name to match the actual zip contract.
|
|
const metaEntry = zip.file('meta.json');
|
|
let hasMetaEntry = false;
|
|
let metaJson: { extensionVersion?: unknown } | null = null;
|
|
if (metaEntry === null) {
|
|
errors.push('meta.json entry missing from archive');
|
|
} else {
|
|
hasMetaEntry = true;
|
|
const metaText = await metaEntry.async('string');
|
|
try {
|
|
metaJson = JSON.parse(metaText) as { extensionVersion?: unknown };
|
|
} catch (parseErr) {
|
|
const msg = parseErr instanceof Error ? parseErr.message : String(parseErr);
|
|
errors.push(`meta.json failed to parse as JSON: ${msg}`);
|
|
}
|
|
if (metaJson !== null) {
|
|
if (typeof metaJson.extensionVersion !== 'string') {
|
|
errors.push(
|
|
`meta.json.extensionVersion expected string, got ${typeof metaJson.extensionVersion} (${JSON.stringify(metaJson.extensionVersion)})`,
|
|
);
|
|
} else if (metaJson.extensionVersion !== expectedVersion) {
|
|
errors.push(
|
|
`meta.json.extensionVersion mismatch — expected "${expectedVersion}", got "${metaJson.extensionVersion}"`,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
hasVideoEntry,
|
|
videoSizeBytes,
|
|
hasMetaEntry,
|
|
metaJson,
|
|
errors,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Extract a single named entry from a .zip to an absolute filesystem
|
|
* path. Used by assertion 12 (ffprobe gate on video/last_30sec.webm).
|
|
*
|
|
* @param zipPath - Absolute path to the .zip.
|
|
* @param entryName - Name of the entry inside the zip (e.g. 'video/last_30sec.webm').
|
|
* @param outPath - Absolute filesystem path to write the entry to.
|
|
* @returns The number of bytes written.
|
|
* @throws If the entry is missing from the zip.
|
|
*/
|
|
export async function extractEntryToFile(
|
|
zipPath: string,
|
|
entryName: string,
|
|
outPath: string,
|
|
): Promise<number> {
|
|
const { writeFileSync } = await import('node:fs');
|
|
const zipBuf = readFileSync(zipPath);
|
|
const zip = await JSZip.loadAsync(zipBuf);
|
|
const entry = zip.file(entryName);
|
|
if (entry === null) {
|
|
throw new Error(`extractEntryToFile: entry '${entryName}' missing in ${zipPath}`);
|
|
}
|
|
const buf = await entry.async('nodebuffer');
|
|
writeFileSync(outPath, buf);
|
|
return buf.byteLength;
|
|
}
|