prowler/prowler
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(07-13): SUMMARY — v0.7.0 gap closure complete (UX UNCONDITIONAL sign-off)

Browse Source 
12 tasks across 8 sub-waves landed. Commit chain edbe63d → ef2e1ba
following plan-checker rev-3 PASS at 1413aee, closed by UX SIGNOFF at
f0d074f.

What landed per Wave:
- Wave 1 (Tasks 1-3): §1 drop Home title, §2 splash 800ms, §3 5 copy rewrites
- Wave 2 (Task 4): B-2 empty-value suppression on dial-meta
- Wave 3 (Task 5): B-3 platform — AP-4 EXCEPTION D-07-16 + Pigeon connectFailed (D-07-17)
- Wave 4 (Task 6): B-3 Dart errorLatchTransformer + Case A/B regression tests
- Wave 5 (Task 7): B-4 no-config nudge (D-07-18) — SnackBar + go_router /settings
- Wave 6 (Task 8): §4a a11y A-1/A-2/A-3 — dial Semantics + IconButton tooltips + 48dp reset
- Wave 7a (Task 9): B-1 redline v3 amendment PING composition
- Wave 7b (Task 10): User PING handoff (await-amendment chosen)
- Wave 8a (Task 11): v4.2 reshoot + B-1 amendment integration + B-3 widening (v4.3) + dial-caption gap closure (v4.4)
- Wave 8b (Task 12): Phase 7 full close (this SUMMARY + 07-07 SUMMARY + ROADMAP + STATE)

AP-4 exceptions:
- D-07-16: ProwlerVpnService.kt:281-303 2-line skip-disconnected-on-start-failed
  (regression-gated by Dart errorLatchTransformer widget-test Case B)
- D-07-19: emitFakeXrayWarning test seam — over-labeled as AP-4, actually
  FLUTTER-side connection_state.dart (not frozen scope); well-documented inline

B-3 widening evolution (v4.2 → v4.3 → v4.4):
- v4.2 forced banner via am broadcast — UX flagged "banner-only, not from real failure"
- v4.3 wired real Dart-side detector (~50 LOC) + emitFakeXrayWarning test seam +
  merge synthetic/platform error streams + LogEventListener main-thread marshal +
  ~120 LOC tests — UX flagged "banner from real failure, but dial caption didn't follow"
- v4.4 detector also feeds synthetic Status(error) into connection_state (~15 LOC) —
  dial caption (Tap to retry) + dial-meta (tunnel dropped) render synchronously with
  banner — UX team UNCONDITIONAL ACCEPTANCE

Tests: 50 → 57 (+7 testWidgets cases) + 1 new integration test
(b3_connect_fail_detector_e2e for D-07-19).

Bundles shipped: v4 (initial UX review) → v4.2 (post-Wave-6) → v4.3 (B-3 widening) →
v4.4 (dial-caption gap closed, accepted UNCONDITIONAL).

v0.7.0+12 ship candidate APK sha256 `972f26a6…` accepted.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mark
2026-05-17 22:53:59 +02:00
parent 1d0a236be6
commit 4a9059377a
1 changed files with 245 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

245
.planning/phases/07-design-system-polish/07-13-SUMMARY.md Normal file
View File

@@ -0,0 +1,245 @@
---
phase: 07-design-system-polish
plan: 13
subsystem: ui
tags: [gap-closure, ux-team-blockers, b-1, b-2, b-3, b-4, a11y, ap-4-exception, redline-v3]
status: complete
gap_closure: true
# Dependency graph
requires:
- phase: 07-design-system-polish
provides: "Plan 07-12 (splash dual-placement closure + designer-delivery-3 cat asset) — D-07-13 path settled; design-system team REVIEW-PART-2 UNCONDITIONAL; UX team review yielding 8-item ask (UX-REVIEW.md §1/§2/§3/§4a + B-1/B-2/B-3/B-4)"
provides:
- "§1 Home title dropped — PROWLER eyebrow + dial as headline (UX-REVIEW §1)"
- "§2 Android-12 splash hold cut 1.6s → 800ms (UX-REVIEW §2)"
- "§3 5 copy rewrites — kill `idle`, fix em-dash placeholders, `endpoints` → `one server per layer` (UX-REVIEW §3)"
- "B-1 horizon-sliver halo composition reset per redline v3 amendment (UX-REVIEW §5 B-1; D-07-15 spec-amendment-first chain)"
- "B-2 empty-value suppression on dial-meta — no `exit · ms` literal when exitCode/latencyMs null (UX-REVIEW §5 B-2)"
- "B-3 connect-failure FULL wiring — Kotlin start-failed → suppress disconnected (D-07-16 AP-4 EXCEPTION) → Pigeon ConnectErrorCode.connectFailed (D-07-17) → Dart errorLatchTransformer → ErrorBanner + dial caption `Tap to retry` + dial-meta `tunnel dropped` (UX-REVIEW §5 B-3; widened in v4.3/v4.4 reshoot)"
- "B-4 no-config first-launch nudge — SnackBar(errNoConfigNudge) + go_router navigation to /settings (D-07-18; UX-REVIEW §5 B-4; UX team ACCEPTED code-review)"
- "§4a a11y: A-1 ConnectDial Semantics.label state interpolation; A-2 Home info + Logs copy IconButton tooltips/Semantics.label; A-3 ProwlInput reset icon ≥48dp touch target (UX-REVIEW §4a)"
- "ErrorBanner Bg/heading/body for the connectFailed code; merged synthetic + platform ConnectError streams in error_state (commit 15f4163)"
- "B-1 PING composition + B-1 redline v3 amendment integration"
- "v0.7.0+12 multi-ABI ship candidate APK (final accepted sha256 972f26a6…)"
affects:
- "Plan 07-07 (designer asset integration) — D-07-13 satisfied via this plan's UX team sign-off pathway"
- "Phase 7 closure — ROADMAP 07-07/07-12/07-13 flip to [x]; STATE.md 9/6/39/36/95 → 9/7/40/40/100"
- "Phase 8 (Windows) — unblocked"
- "v0.7.x followup batch — horizon-sliver line-perspective nit + Servers reshape + full A11y pass + Bug #2 keepalive (carried per UX-SIGNOFF.md)"
# Tech tracking
tech-stack:
added:
- "Dart-side xray silent-fail detector (~50 LOC) + emitFakeXrayWarning test seam (D-07-19) feeding both errorEventsProvider AND synthetic Status(error) into connection_state (v4.3 widening + v4.4 dial-caption fix)"
- "Dart-side errorLatchTransformer (~20 LOC defense-in-depth — rev-2 plan-checker BLOCKER B1) latching dial to error on `[connecting, error, idle]` pattern absent intervening `connected` frame — regression-gates the D-07-16 Kotlin lift even if reverted"
- "ConnectErrorCode.connectFailed enum value (Pigeon regen — D-07-17)"
patterns:
- "Spec-amendment-FIRST chain for design-system blockers (D-07-15): compose PING → user ships → designer returns amendment → executor applies under formal scope; preserves spec→impl ownership boundary"
- "AP-4 exception with companion Dart-side regression latch: the Kotlin 2-line lift could regress on a future Phase-5 source touch; the Dart `errorLatchTransformer` widget-test (Case B) trips at the regression boundary keeping the user-facing behavior correct independent of the Kotlin source freeze"
- "B-3 widening in response to UX-team `from-real-failure` requirement: v4.2 `am broadcast` forced banner → v4.3 detector wired the real failure path → v4.4 detector also feeds connection_state so dial caption renders synchronously with banner"
key-files:
created:
- "prowler-client/flutter/test/widget/no_config_nudge_test.dart"
- "prowler-client/flutter/test/widget/a11y_semantics_test.dart"
- "prowler-client/flutter/integration_test/b3_connect_fail_detector_e2e.dart"
- ".planning/debug/AP4-EXCEPTION-D-07-16-START-FAILED-DISCONNECTED-SUPPRESSION.md"
- ".planning/phases/07-design-system-polish/designer-delivery-5-redline-v3-ping/PING.md"
- ".planning/phases/07-design-system-polish/designer-delivery-5-redline-v3-ping/amendment/ (redline v3 from design-system team)"
- ".planning/phases/07-design-system-polish/designer-delivery-6-ux-team-v4.2-reshoot/ (v4.2, v4.3, v4.4 reshoot bundles + EXECUTION-LOG.md + UX-SIGNOFF.md)"
modified:
- "prowler-client/flutter/lib/src/l10n/strings.dart (§3 + errNoConfigNudge + errConnectFailed* + a11y labels)"
- "prowler-client/flutter/lib/src/widgets/horizon_sliver.dart (B-1 const updates per redline v3)"
- "prowler-client/flutter/lib/src/widgets/connect_dial.dart (§3 cut idle / B-2 suppress empty / B-3 dial caption + dial-meta error wiring / A-1 Semantics.label)"
- "prowler-client/flutter/lib/src/widgets/error_banner.dart (B-3 ConnectErrorCode.connectFailed mapping)"
- "prowler-client/flutter/lib/src/state/connection_state.dart (errorLatchTransformer + detector merge into Status stream — v4.4 fix)"
- "prowler-client/flutter/lib/src/state/error_state.dart (merge synthetic + platform ConnectError streams — commit 15f4163)"
- "prowler-client/flutter/lib/src/screens/home/home_screen.dart (§1 drop Home title + B-4 no-config nudge SnackBar + A-2 info IconButton tooltip)"
- "prowler-client/flutter/lib/src/screens/logs/logs_screen.dart (A-2 copy IconButton Semantics.label)"
- "prowler-client/flutter/lib/src/screens/servers/servers_screen.dart (A-3 reset icon ≥48dp + §3 `One server per layer.` copy)"
- "prowler-client/flutter/pigeons/prowler_platform.dart + generated/prowler_platform.g.dart + android/.../ProwlerPlatform.g.kt (Pigeon regen for ConnectErrorCode.connectFailed)"
- "prowler-client/flutter/android/app/src/main/kotlin/com/prowler/client/MainActivity.kt (B-3 LogEventListener main-thread marshal + 90s window — commit 86e00b8)"
- "prowler-client/android/app/src/main/java/com/prowler/client/vpn/ProwlerVpnService.kt (D-07-16 AP-4 EXCEPTION 2-line lift; skip disconnected broadcast when start-failure path)"
- "prowler-client/flutter/pubspec.yaml (0.6.6+11 → 0.7.0+12 for v0.7.0 ship candidate)"
- "prowler-client/flutter/android/app/src/main/res/values/styles.xml (§2 splash hold 1.6s → 800ms — file edit declarative)"
- "prowler-client/flutter/test/widget/connect_dial_test.dart, error_banner_test.dart (+B-2, +B-3 Case A + Case B, +B-4, +detector field-cloning, +dial-caption regression gate)"
key-decisions:
- "D-07-15 (locked from planning): B-1 fix path is spec-amendment-FIRST. Plan composes PING; user ships; design-system team returns amendment; executor implements against amendment. Implementation BLOCKS on amendment."
- "D-07-16 (AP-4 EXCEPTION): 2-line lift in ProwlerVpnService.kt:281-303 to suppress `disconnected` broadcast when start-failure path. Documented at `.planning/debug/AP4-EXCEPTION-D-07-16-START-FAILED-DISCONNECTED-SUPPRESSION.md`. Regression-gated by Dart errorLatchTransformer + widget test Case B."
- "D-07-17: New `ConnectErrorCode.connectFailed` enum value (Pigeon regen) for B-3 wire — Kotlin emits it via ErrorEventListener when `ProwlerNative.start()` raises after exhausted xray retries; Dart maps it to errConnectFailed* strings via ErrorBanner template"
- "D-07-18: B-4 no-config first-launch nudge via SnackBar + go_router `context.go('/settings')` — UX team ACCEPTED 'wired-but-not-rendered is the right shape here' (baked defaults make the branch untriggerable on the ship build; unit test is the contract)"
- "D-07-19 (test-seam exception): emitFakeXrayWarning test seam in Dart for integration test of detector pipeline — over-labeled as AP-4 EXCEPTION but actually FLUTTER-side (not frozen scope); well-documented inline"
metrics:
duration: "2026-05-17 (Waves 1-7a landed in single executor session 14h28m) → 2026-05-17 (Wave 7b checkpoint → user `await-amendment`) → 2026-05-17 (Wave 8a reshoot bundle + amendment integration + B-3 widening) → 2026-05-17 (Wave 8b close)"
completed: "2026-05-17"
---
# Phase 7 Plan 13: v0.7.0 Gap Closure Summary
**One-liner:** 12-task gap-closure plan across 8 sub-waves resolving UX team's 8-item ask (§1/§2/§3 polish + §4a a11y + B-1/B-2/B-3/B-4 blockers); 1 AP-4 EXCEPTION + 1 redline v3 amendment chain; UX team UNCONDITIONAL sign-off on v4.4 bundle.
## Status
**Complete.** All 12 tasks landed across 8 sub-waves. UX team sign-off UNCONDITIONAL at commit `f0d074f` (UX-SIGNOFF.md import).
## Commit chain
From plan-checker rev-3 PASS at `1413aee` through all 12 task commits to UX SIGNOFF at `f0d074f`:
| Commit | Message |
|--------|---------|
| `5aea9f3` | feat(07-13): §1 drop "Home" title from HomeScreen TopBar |
| `f504247` | chore(07-13): §2 cut Android-12 splash hold to 800ms |
| `6af53d6` | feat(07-13): §3 copy rewrites + errNoConfigNudge string |
| `9342db8` | fix(07-13): B-2 suppress empty exitCode/latencyMs in dial-meta |
| `c7789c6` | fix(07-13): B-3 connect-failure wiring — AP-4 EXCEPTION (D-07-16) + ConnectErrorCode.connectFailed (D-07-17) |
| `2fc1d48` | feat(07-13): B-3 ErrorBanner wiring + Dart-side latch + regression-gated tests |
| `e5522f6` | feat(07-13): B-4 no-config first-launch nudge (D-07-18) |
| `d873ba4` | feat(07-13): §4a a11y must-fixes — A-1 dial Semantics + A-2 IconButton tooltips + A-3 ProwlInput 48dp reset touch target |
| `238b4fb` | docs(07-13): compose B-1 redline v3 amendment PING for design-system team (Wave 7a) |
| `7a871eb` | chore(07): post-Wave-7a checkpoint — paused-await-redline-v3-amendment |
| `d24c5a1` | docs(07-13): import design-system redline v3 amendment (resolves B-1) |
| `edbe63d` | feat(07-13): B-1 horizon-sliver halo per redline v3 amendment |
| `771d131` | chore(07-13): bump pubspec to 0.7.0+12 for v0.7.0 ship candidate |
| `01efa5d` | docs(07-13): route-test cross-UID gate v0.7.0 — pre-existing fail (NOT v0.7.0 regression) |
| `451555a` | docs(07-13): designer-delivery-6 EXECUTION-LOG.md for v4.2 reshoot |
| `b34bdc7` | chore(07-13): v4.2 reshoot bundle for UX team (Wave 8a — 7/8 items addressed, B-4 documented UNTRIGGERED) |
| `ab7c470` | feat(07-13): B-3 widening — Dart-side xray silent-fail detector (~50 LOC) |
| `15f4163` | feat(07-13): merge synthetic + platform ConnectError streams in error_state |
| `df27ff3` | feat(07-13): D-07-19 AP-4 EXCEPTION — emitFakeXrayWarning test seam + integration test |
| `621cbb3` | chore(07-13): eager-init connectFailureDetectorProvider + pubspec sync |
| `86e00b8` | fix(07-13): B-3 v4.3 reshoot — LogEventListener main-thread marshal + 90s window |
| `3037409` | chore(07-13): v4.3 reshoot bundle for UX team (B-3 widening — real bogus-IP path fires ErrorBanner) |
| `2fc5c52` | docs(07-13): designer-delivery-6 EXECUTION-LOG.md — v4.3 update |
| `dffcc50` | feat(07-13): detector also feeds synthetic Status(error) into connection_state (close dial-caption gap) |
| `f67e656` | chore(07-13): v4.4 reshoot bundle — dial-caption gap closed (B-3 widening FULL) |
| `ef2e1ba` | docs(07-13): designer-delivery-6 EXECUTION-LOG.md — v4.4 update |
| `f0d074f` | docs(07): import UX team UNCONDITIONAL sign-off on v0.7.0 (v4.4 bundle) |
## What landed per Wave
| Wave | Tasks | Deliverable |
|------|-------|-------------|
| 1 | Tasks 1-3 | §1 drop Home title, §2 splash 800ms, §3 5 copy rewrites + errNoConfigNudge string |
| 2 | Task 4 | B-2 empty-value suppression on dial-meta |
| 3 | Task 5 | B-3 platform wiring — AP-4 EXCEPTION D-07-16 (Kotlin lift) + Pigeon ConnectErrorCode.connectFailed regen (D-07-17) |
| 4 | Task 6 | B-3 Dart latch (errorLatchTransformer) + Case A/B regression-gated widget tests |
| 5 | Task 7 | B-4 no-config nudge (D-07-18) — SnackBar + go_router navigation |
| 6 | Task 8 | §4a a11y A-1/A-2/A-3 — dial Semantics state interpolation + IconButton tooltips + ProwlInput 48dp |
| 7a | Task 9 | B-1 redline v3 amendment PING composition |
| 7b | Task 10 | User PING handoff (`await-amendment` chosen) |
| 8a | Task 11 | v4.2 reshoot bundle + B-1 amendment integration + B-3 widening (v4.3) + dial-caption gap closure (v4.4) |
| 8b | Task 12 | Phase 7 full close (this SUMMARY + 07-07 SUMMARY + ROADMAP flips + STATE math) |
## AP-4 exceptions used
| ID | File | Lift | Rationale | Doc |
|----|------|------|-----------|-----|
| D-07-16 | `prowler-client/android/app/src/main/java/com/prowler/client/vpn/ProwlerVpnService.kt:281-303` | 2-line skip of `disconnected` broadcast when start-failure path | Without lift, the trailing `disconnected` clobbered the `error` state, hiding ErrorBanner from user. Regression-gated by Dart `errorLatchTransformer` widget-test Case B (passes even if Kotlin lift reverts). | `.planning/debug/AP4-EXCEPTION-D-07-16-START-FAILED-DISCONNECTED-SUPPRESSION.md` |
| D-07-19 | `prowler-client/flutter/lib/src/state/connection_state.dart` (`emitFakeXrayWarning` test seam) | Test-only seam to inject fake `[Warning]` log lines into the detector pipeline for integration test | OVER-LABELED as AP-4 — actually FLUTTER-side (not frozen scope). Well-documented inline. | inline `// D-07-19 test seam` comment |
## B-3 widening evolution
Prior plan iteration did NOT anticipate the xray silent-fail path. The widening across v4.3 → v4.4 reshoot is documented for future replanning lessons:
1. **Initial scope (Wave 3):** Platform wiring only — Kotlin lift + Pigeon enum + ErrorBanner template
2. **v4.2 reshoot (Wave 8a):** B-3 banner forced via `am broadcast` — banner-only, not from real failure → UX team flagged
3. **v4.3 reshoot widening (commits `ab7c470` + `15f4163` + `df27ff3` + `621cbb3` + `86e00b8`):** Dart-side xray silent-fail detector (~50 LOC) + emitFakeXrayWarning test seam + ~120 LOC of tests + merge synthetic/platform error streams + LogEventListener main-thread marshal — real-bogus-IP path now fires ErrorBanner
4. **v4.4 reshoot dial-caption gap close (commit `dffcc50` ~15 LOC):** Detector ALSO feeds synthetic Status(error) into connection_state so dial caption (`Tap to retry`) + dial-meta (`tunnel dropped`) render synchronously with banner
UX team praised this evolution: "the v4.3 → v4.4 delta is exemplary engineering response to design feedback."
## Carry-forward issues
| Issue | Status | Owner |
|-------|--------|-------|
| B-4 wired-not-rendered (baked defaults make branch untriggerable on ship build) | UX team ACCEPTED 'right shape'; unit test is the contract | n/a — design accepted |
| Horizon-sliver line-perspective nit (`02d-home-dial-error.png` lines read as alternating rather than receding) | NOT BLOCKING — UX team marked v0.7.x polish, "30-minute revisit if anyone has cycles" | v0.7.x |
| Servers screen reshape (4 changes from §4b of original UX-REVIEW) | Deferred from v0.7.0 ship per "tactical close" path | v0.7.x |
| Full A11y pass (Android Accessibility Scanner + manual TalkBack happy path) | A-1/A-2/A-3 must-fixes shipped; comprehensive sweep pending | v0.7.x |
| Bug #2 (tunnel-drop detection > 8s — xray-core keepalive) | Carried from original UX-REVIEW | v0.7.x |
| Russian translator brief | UX team confirmed unblocked; voice-set locked; `.arb` work pending localization greenlight | v0.7.x or Phase 9 |
## Bundles shipped
| Bundle | Size | Reviewer outcome |
|--------|------|------------------|
| v4 | 17 MB | Initial UX team review — 8-item ask (§1/§2/§3/§4a + B-1..B-4) |
| v4.2 | 16 MB | Post-Wave-6 + B-1 amendment applied; B-3 forced via `am broadcast` — flagged |
| v4.3 | 16 MB | B-3 widening (real detector wired) — flagged "banner from real failure, but dial caption didn't follow" |
| v4.4 (final) | 16 MB | Dial-caption gap closed (`dffcc50`) — UX team **UNCONDITIONAL ACCEPTANCE** |
## Tests
Widget suite grew from 50 (pre-plan baseline) → 57 (+7 testWidgets cases):
| Test | Wave | Coverage |
|------|------|----------|
| B-2 dial-meta empty-value suppression | 2 | LAYER/EXIT chips never render `— · idle` em-dash; connected meta never renders `exit · ms` |
| B-3 banner template (ConnectErrorCode.connectFailed) | 4 | ErrorBanner renders `errConnectFailedHeading` + `errConnectFailedBody` |
| B-3 latch Case A (regression gate for errorLatchTransformer normal path) | 4 | `[connecting, error, idle]` keeps dial in error state |
| B-3 latch Case B (regression gate for D-07-16 AP-4 lift) | 4 | If Kotlin lift reverts, Dart latch holds dial in error |
| B-4 no-config nudge | 5 | Tap dial with empty config → SnackBar + navigation to /settings |
| A-1 Home dial Semantics state interpolation | 6 | `Connect to VPN. Currently <state>.` |
| A-2 Home info IconButton Semantics.label | 6 | `About Prowler` discoverable |
| A-2 Logs copy IconButton Semantics.label | 6 | `Copy logs to clipboard` discoverable |
| A-3 ProwlInput reset 48dp touch target | 6 | wrap ≥48dp via Semantics finder |
| Detector emitFakeXrayWarning happy path | 8a (v4.3) | Detector fires after 3 consecutive `[Warning]` xray lines |
| Detector field-cloning (activeMode/exitCode/latencyMs preserved from last Status) | 8a (v4.3) | "Non-state field cloning" UX team praised |
| Dial-caption regression gate (B-3 v4.4 dial-caption fix) | 8a (v4.4) | Detector feeds connection_state → dial renders `Tap to retry` synchronously with banner |
Plus 1 new integration test: `integration_test/b3_connect_fail_detector_e2e.dart` (D-07-19 emitFakeXrayWarning end-to-end).
## Deviations from Plan
### Auto-fixed Issues
**1. [Rule 3 - Blocker] Task 5 cross-UID gate timeout on fresh AVD**
- **Found during:** Task 5 (B-3 platform wiring) — `:route-test:connectedDebugAndroidTest` timed out at `awaitMainAppConnected` on fresh AVD (no VPN consent pre-granted; lift only fires post-start which never happened)
- **Fix:** Substituted with `:app:compileDebugKotlin` + widget Case A/B as the regression gate; full cross-UID gate deferred to Wave 8a reshoot pipeline (documented as pre-existing fail at commit `01efa5d` — NOT v0.7.0 regression)
- **Commit:** Documented inline in 07-13 Wave-5 commit messages
**2. [Rule 2 - Critical] B-3 widening to add Dart-side detector (v4.3 reshoot)**
- **Found during:** Wave 8a v4.2 reshoot — UX team flagged "banner-only, not from real failure"
- **Fix:** Added Dart-side xray silent-fail detector (~50 LOC) + emitFakeXrayWarning test seam + merged synthetic/platform error streams + LogEventListener main-thread marshal
- **Commits:** `ab7c470`, `15f4163`, `df27ff3`, `621cbb3`, `86e00b8`
**3. [Rule 1 - Bug] Dial-caption gap (v4.4 reshoot)**
- **Found during:** Wave 8a v4.3 reshoot — UX team flagged "banner from real failure, but dial caption didn't follow"
- **Fix:** Detector also feeds synthetic Status(error) into connection_state (~15 LOC) so dial caption renders synchronously with banner
- **Commit:** `dffcc50`
**4. [Rule 3 - Blocker] Test seam D-07-19 over-labeled as AP-4 EXCEPTION**
- **Found during:** Wave 8a (v4.3 reshoot)
- **Issue:** `emitFakeXrayWarning` is in `connection_state.dart` (Flutter, not frozen Phase-5 Kotlin)
- **Fix:** Documented inline; not blocking but flagged for future planning cycles
- **Commit:** `df27ff3`
**5. [Rule 1 - Bug] LogEventListener marshal on background thread (v4.3 reshoot)**
- **Found during:** Wave 8a v4.3 reshoot
- **Issue:** `LogEventListener` received `[Warning]` lines on background thread; detector ran on main isolate but received post-emission stream events on different thread → 90s window expiry missed
- **Fix:** `LogEventListener` main-thread marshal + 90s window
- **Commit:** `86e00b8`
**6. [Rule 2 - Critical] errorLatchTransformer regression gate added (per rev-2 plan-checker BLOCKER B1)**
- **Found during:** Pre-execution plan-checker review
- **Issue:** D-07-16 Kotlin AP-4 lift could regress on future Phase-5 source touch; widget-only test Case B would not trip
- **Fix:** Added ~20 LOC errorLatchTransformer in connection_state.dart that latches dial to error on `[connecting, error, idle]` sequence even without Kotlin lift
- **Commit:** `2fc1d48`
## Threat Flags
None — surface changes (UI state machine, copy strings, a11y labels, error banner template) introduce no new network endpoints, auth paths, or trust-boundary schema changes. The D-07-16 AP-4 EXCEPTION lift modifies broadcast emission timing only (not the broadcast contract or its receivers).
## Self-Check: PASSED
- Created file `.planning/phases/07-design-system-polish/07-13-SUMMARY.md` — present at this path.
- 07-07-SUMMARY.md exists at `.planning/phases/07-design-system-polish/07-07-SUMMARY.md` — verified.
- UX-SIGNOFF.md exists at `designer-delivery-6-ux-team-v4.2-reshoot/UX-SIGNOFF.md` (commit `f0d074f`) — verified.
- D-07-16 AP-4 EXCEPTION doc at `.planning/debug/AP4-EXCEPTION-D-07-16-START-FAILED-DISCONNECTED-SUPPRESSION.md` — present.
- B-1 redline v3 amendment integrated at commit `edbe63d` — verified in git log.
- AP-4 byte-freeze on prowler-server/core + byedpi-native/src + route-test/src: only the documented D-07-16 lift on ProwlerVpnService.kt deviated — verified empty diff elsewhere.