docs(04-07): closure markers — REQUIREMENTS + ROADMAP + STATE + PROJECT for Phase 4 v1 close-prep
Task 2 of Plan 04-07 — 4 marker file flips landing Phase 4 closure-prep (NOT formal Phase 4 closure; that happens at the ceremony AFTER the independent gsd-verifier audit per Phase 1-3 precedent). ROADMAP.md: - Plan 04-07 row flipped [ ] → [x] with full closure annotation (04-VERIFICATION.md citation + Phase 4 cumulative totals + D-P4-05 backfill verification + closure- ceremony deferral note) - Phase 4 progress table cell updated 7/8 → 8/8 with full closure-prep narrative - Phase 4 row [ ] LEFT UNFLIPPED — verifier audit + closure ceremony flips it STATE.md: - progress.completed_plans: 29 → 30 + progress.percent: 93 → 97 - progress.completed_phases: 3 (UNCHANGED) + status: executing (UNCHANGED) - stopped_at + last_updated + last_activity updated for Plan 04-07 closure - Current Position block updated to reflect Plan 04-07 completion + pending closure ceremony - Plan 04-07 closure section added at top of body - Performance metrics row added for Phase 04 P07 - Session Continuity entry prepended for Plan 04-07 - 2 Phase 04-07 decisions appended to Decisions list REQUIREMENTS.md: - 4 Phase 4 closure notes appended to existing REQ blocks (no existing REQ-* lines modified): - REQ-video-ring-buffer: ROADMAP SC #1 via Plan 04-08 (methodology reframe) - REQ-rrweb-dom-buffer: A29 cs-injection-world + UAT 33→36 GREEN summary - REQ-user-event-log: ROADMAP SC #2 via Plan 04-05 + audit P1 #11/#14/#15 via Plan 04-01 - REQ-install-clean: ROADMAP SC #3/SC #4/Plan 04-02 build hygiene + Plan 04-08 Tier-2 leak gate - Trailing footer line updated with 2026-05-26 Phase 4 closure citation PROJECT.md: - NEW Validated in Phase 4 section added (7 bullets covering all closures) - Active section evolved from Phase 4 backlog → Phase 4 closure-ceremony workstream + Deferred-to-v1.1/v2 maintenance milestone items - Trailing footer line updated with 2026-05-26 Phase 4 closure citation Acceptance criteria gates (all PASS per Plan 04-07 Task 2): - ROADMAP.md 04-07 row [x] = 1 - ROADMAP.md Phase 4 row [x] = 0 (correctly LEFT unflipped) - STATE.md completed_phases: 3 = 2 (frontmatter + body — UNCHANGED per spec) - STATE.md completed_plans: 30 = 1 (incremented by 1) - STATE.md status: executing = 1 (UNCHANGED per spec) - REQUIREMENTS.md "Phase 4 closure note" mentions = 4 (>= 3) - PROJECT.md "Validated in Phase 4" section = 1 - git diff --stat HEAD~1 HEAD shows only .planning/ files dirty (T-04-07-02 threat mitigation gate honored — docs-only commit; no source/test changes) Phase 4 row + completed_phases bump + status:completed flip explicitly DEFERRED to closure ceremony after the independent gsd-verifier audit per Phase 1-3 precedent (executor creates VERIFICATION.md; verifier independently re-validates with goal-backward audit; orchestrator flips markers post-verifier-audit).
This commit is contained in:
@@ -42,23 +42,31 @@ output.
|
||||
- [x] 10 min user/runtime event log (REQ-user-event-log; A30 harness coverage verifies all 5 UserEvent types — click + input + navigation + js_error + network_error; password filtering verified via A31 PARTIAL per D-P3-02 charter)
|
||||
- [x] SPEC §10 full acceptance criteria sweep #1-#9 — Phase 1 (§10 #1/#2/#3/#7) + Phase 2 (§10 #6) + Phase 3 (§10 #4/#5/#8 PARTIAL/#9 best-effort) — 03-VERIFICATION.md aggregates evidence with T5 override pattern
|
||||
|
||||
**Validated in Phase 4 (closed 2026-05-26 via executor-created aggregator 04-VERIFICATION.md; pending independent gsd-verifier audit + closure-ceremony marker flips):**
|
||||
- [x] All 4 ROADMAP success criteria CLOSED (SC #1 SW state persistence via Plan 04-08 methodology reframe — HTMLVideoElement.captureStream replaces canvas.captureStream; 1.8 MB videoSize vs 8505 baseline; SC #2 fetch + XHR network_error empirical via Plan 04-05 A34 — 2 entries with meta.status===404; SC #3 generate-icons ESM/CJS via Plan 04-02 `git mv .js → .cjs`; SC #4 dead-code grep via Plan 04-02 tests/build/dead-code-grep.test.ts regression pin)
|
||||
- [x] All 3 audit P1 polish items CLOSED (P1 #11 fetch URL extraction + P1 #14 navigation URL tracking + P1 #15 rrweb timestamp normalization — all via Plan 04-01 D-P4-02 single dedicated TDD plan; src/content/index.ts surgical edits + 9 unit tests at NEW tests/content/ directory)
|
||||
- [x] All 6 cross-cutting hardening items GREEN (setimmediate polyfill 4-mechanism mitigation via Plan 04-02; A29 cs-injection-world rewrite via Plan 04-03 — 5/5 PASS stress vs ~2/3 historical; cursor visibility regression-pinned via Plan 04-06 — shipped opportunistically by Plan 01-09; dark-surface logo contrast via Plan 04-06 — currentColor + DOMParser inline-SVG + NEW `--mks-mark-stroke` brand-component token decoupled from theme-flipping `--mks-fg-inverse` semantic token)
|
||||
- [x] D-P4-02 + D-P4-03 + D-P4-05 charters CLOSED (D-P4-02 all 3 audit P1 polish items via Plan 04-01; D-P4-03 both visual polish items via Plan 04-06; D-P4-05 ROADMAP backfill verification for Plans 01-08..01-14 via Plan 04-07). D-P4-01 + D-P4-04 honored throughout (D-P4-01 full Phase 4 scope; D-P4-04 alpha out-of-band).
|
||||
- [x] Cross-cutting gates: UAT harness 33 → 36 GREEN (+A33 + A34 + A35 with 5 sub-checks incl. A35.5 light+dark equality decouple-proof); vitest 171 → 188 GREEN (+17 tests across Plans 04-01/02/06/08); pre-checkpoint bundle gates 6/6 PASS (Gate 2 polarity flipped 1 → 0 via Plan 04-02 — closes Plan 01-12 Wave 7 setimmediate deferred-items entry end-to-end); Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12; NEW Tier-2 production-bundle filename-leak gate added by Plan 04-08
|
||||
- [x] /gsd-debug sessions: 3 documented + resolved (canvas-throttling sessions 1+2 → REFUTED-architecture verdict authorizing Plan 04-08 insertion; Plan 04-06 dark-mode mark decoupling → fix at commit a8bcc17; A33.1 SAVE-ack race → fix at commit 7e0da63)
|
||||
- [x] Operator-empirical ack 2026-05-26 verbatim "Confirmed fixed — close Plan 04-06" (Plan 04-06 Task 4 cycle-2 after debug-fix; canonical aesthetics-judgment-is-non-automatable case per `feedback-trust-harness-over-manual-uat.md`)
|
||||
|
||||
### Active
|
||||
|
||||
<!-- Current scope. Building toward these. See REQUIREMENTS.md for IDs. -->
|
||||
|
||||
**Phase 4 (Harden + clean up — optional):**
|
||||
- Phase 5-style P1/P2 follow-ups + accumulated session backlog (12 deferred items in 03-VERIFICATION.md):
|
||||
- rrweb v2 stable upgrade (D-P3-03 defer)
|
||||
- Programmatic SW-context RAM measurement via chrome.devtools Memory API (D-P3-04 defer)
|
||||
- REQ-password-confidentiality v2 candidate (only if charter reverses)
|
||||
- A29 iana.org leftover race (cs-injection-world is natural fix candidate per Plan 03-02)
|
||||
- Pre-existing ffprobe/ffmpeg vitest intermittent flake
|
||||
- getDisplayMedia cursor visibility refinement (Plan 01-07 obs)
|
||||
- Dark-surface logo contrast (Plan 01-10 obs)
|
||||
- setimmediate polyfill hardening (Plan 01-12 obs)
|
||||
- Audit P1 #11/#14/#15 polish (fetch Request→[object], navigation URL, rrweb timestamp semantics)
|
||||
**Phase 4 closure ceremony (post Plan 04-07):**
|
||||
- Independent gsd-verifier audit of `.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md` (Phase 1-3 precedent — verifier re-validates executor-created aggregator with goal-backward audit)
|
||||
- ROADMAP.md Phase 4 row `[ ]` → `[x]` flip + CLOSED 2026-05-26 annotation
|
||||
- STATE.md `progress.completed_phases: 3 → 4` + `progress.percent: 97 → 100` + `status: executing → completed` flip
|
||||
- v1.0 tag + release notes + alpha redistribution (separate workstream per D-P4-04 charter — user-routed out-of-band)
|
||||
|
||||
**Milestone v1 may close at Phase 3** if Phase 4 is deferred to v2 — Phase 4 is explicitly optional per ROADMAP.
|
||||
**Deferred to v1.1 / v2 maintenance milestones:**
|
||||
- rrweb 2.0.0-alpha.4 → stable v2 upgrade (D-P3-03 + D-P4-01 charter; alpha-pin stable across all 31 plans + 36/36 UAT GREEN)
|
||||
- Programmatic SW-context RAM measurement via chrome.devtools.Memory API (D-P3-04 + D-P4-01 charter; A32 best-effort + chrome://memory-internals + alpha distribution coverage accepted)
|
||||
- REQ-password-confidentiality v2 candidate (D-P3-02 charter shift 2026-05-20 — only revisit if charter reverses on "we don't care about privacy hardening")
|
||||
- A29/A30/A31 cs-injection-world flake family (intermittent in full-suite runs; A29 specifically CLOSED via Plan 04-03 strict-sentinel; A30/A31 NOT in Plan 04-03 charter)
|
||||
- 04-CONTEXT #9/#10 parallel-vitest ffprobe-timeout flake family (true clean baseline corrected to 188/188 GREEN; canonical Vitest mitigation: poolOptions.threads.singleThread:true OR raised testTimeout)
|
||||
|
||||
### Out of Scope
|
||||
|
||||
@@ -179,4 +187,4 @@ The verbatim list lives in REQUIREMENTS.md under "Phase 1 Acceptance Criteria
|
||||
(SPEC §10 verbatim)".
|
||||
|
||||
---
|
||||
*Last updated: 2026-05-20 — Phase 3 closure (verifier audit PASSED 5/5 ROADMAP + 9/9 SPEC §10 with 4 overrides; REQ-rrweb-dom-buffer + REQ-user-event-log + SPEC §10 sweep all moved Active → Validated; §10 #9 RAM user-acked on A32 best-effort + alpha distribution coverage). Prior: 2026-05-20 Phase 2 closure; 2026-05-15 initial bootstrap.*
|
||||
*Last updated: 2026-05-26 — Phase 4 closure aggregator created via Plan 04-07 (`.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md`; 253 lines; 4/4 ROADMAP SC + 3/3 audit P1 + 6/6 hardening items GREEN; UAT 36/36 + vitest 188/188 + 6/6 bundle gates + Tier-1=12 + NEW Tier-2; 3 /gsd-debug sessions; operator empirical ack "Confirmed fixed — close Plan 04-06" 2026-05-26). Phase 4 row [x] flip + completed_phases 3→4 + status:completed flip DEFERRED to closure ceremony after independent gsd-verifier audit (Phase 1-3 precedent). Prior: 2026-05-20 Phase 3 closure (verifier audit PASSED 5/5 ROADMAP + 9/9 SPEC §10 with 4 overrides); 2026-05-20 Phase 2 closure; 2026-05-15 initial bootstrap.*
|
||||
|
||||
@@ -49,6 +49,18 @@ Requirements for the Phase 1 SPEC. Each maps to one phase in ROADMAP.md.
|
||||
`.planning/debug/d13-multi-ebml-concat-unplayable.md` for the
|
||||
byte-level root-cause evidence.
|
||||
|
||||
Phase 4 closure note (2026-05-26): ROADMAP SC #1 (SW state persistence — after
|
||||
>5min idle + export, archive still contains non-empty video buffer)
|
||||
empirically verified via Plan 04-08 A33 harness assertion. Spike re-run at
|
||||
tests/uat/spike-a33-sw-persistence.ts produces videoSize=1,797,178 bytes
|
||||
(1.8 MB) vs 8505-byte baseline; offscreen RAM-only `segments: Blob[]` at
|
||||
src/offscreen/recorder.ts:91 architecturally sound (segments survive SW kill
|
||||
structurally — POST-KILL probe count=3); previous Plan 04-04 SPIKE FAILED
|
||||
outcome was test-methodology issue (canvas.captureStream invisible-source
|
||||
throttling per Chrome bug 653548), not architectural. See
|
||||
.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md
|
||||
Per-Requirement Scorecard SC #1 row.
|
||||
|
||||
### DOM Capture
|
||||
|
||||
- [x] **REQ-rrweb-dom-buffer**: The extension records DOM events via rrweb
|
||||
@@ -69,6 +81,19 @@ Requirements for the Phase 1 SPEC. Each maps to one phase in ROADMAP.md.
|
||||
canonical for SPEC §10 #4; operator UAT retired by explicit delegation).
|
||||
VERIFICATION at .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VERIFICATION.md.
|
||||
|
||||
Phase 4 closure note (2026-05-26): A29 cs-injection-world rewrite + strict-
|
||||
sentinel filter (Plan 04-03 commits 73eb9b6 + b341a71) — flake closed 5/5
|
||||
PASS across consecutive UAT runs (was ~2/3 historical baseline per Plan
|
||||
03-03 SUMMARY); iana.org-leftover flake CLOSED. driveA29 host-side strict-
|
||||
sentinel filter requires IncrementalSource.Mutation + adds[*].node.textContent
|
||||
containing 'a29-mutation-sentinel' (only our injection can produce). A29.2
|
||||
strict-sentinel = PRIMARY check; A29.3 (Meta) + A29.4 (FullSnapshot) preserved
|
||||
as defense-in-depth. UAT harness 33 → 36 GREEN end-of-Phase-4 (+A33 SW state
|
||||
persistence via Plan 04-08; +A34 fetch+XHR network_error via Plan 04-05;
|
||||
+A35 live-DOM inline-SVG via Plan 04-06 with 5 sub-checks incl. A35.5 light+
|
||||
dark equality decouple-proof). See 04-VERIFICATION.md Cross-Cutting Hardening
|
||||
Items row H2.
|
||||
|
||||
### Event Logging
|
||||
|
||||
- [x] **REQ-user-event-log**: The extension logs user and runtime events over
|
||||
@@ -95,6 +120,24 @@ Requirements for the Phase 1 SPEC. Each maps to one phase in ROADMAP.md.
|
||||
charter — REQ-password-confidentiality remains Out of Scope v1).
|
||||
VERIFICATION at .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VERIFICATION.md.
|
||||
|
||||
Phase 4 closure note (2026-05-26): ROADMAP SC #2 (fetch + XHR network_error
|
||||
empirical capture) CLOSED via Plan 04-05 (A34 commits a20372a + 0712c24) —
|
||||
cs-injection-world fires fetch(404) + XMLHttpRequest(404) from a probe tab
|
||||
on https://example.com; driveA34 host-side JSZip-parses logs/events.json
|
||||
and confirms 2 network_error entries with meta.status === 404 (skip-mode
|
||||
UAT 35/35 GREEN; A34 real ~25s; all 6 sub-checks PASS — A34.1 SAVE ack +
|
||||
A34.0a events.json present + A34.2 fetch entry + A34.3 XHR entry + A34.4
|
||||
fetch meta.status===404 + A34.5 XHR meta.status===404).
|
||||
Plan 04-01 P1 #11 fetch URL extraction fix validated end-to-end via A34.4 —
|
||||
the fetch network_error entry's target carries the real URL
|
||||
(`https://example.com/404-fetch-a34-<stamp>`) NOT the literal `[object Request]`
|
||||
that the pre-fix `args[0]?.toString()` implicit coercion produced. Plan 04-01
|
||||
P1 #14 navigation URL tracking (module-level `let previousUrl` at
|
||||
src/content/index.ts:29) + P1 #15 rrweb timestamp normalization (Date.now()
|
||||
at emit time at line 315) are unit-tested at tests/content/ (9 tests across
|
||||
3 files in NEW tests/content/ directory). See 04-VERIFICATION.md
|
||||
Per-Requirement Scorecard SC #2 row + Audit P1 Polish #11/#14/#15 rows.
|
||||
|
||||
### Export
|
||||
|
||||
- [x] **REQ-screenshot-on-export**: On "Save archive" click, the extension
|
||||
@@ -209,6 +252,23 @@ Requirements for the Phase 1 SPEC. Each maps to one phase in ROADMAP.md.
|
||||
"all good" on the empirical load.
|
||||
- SPEC §10 acceptance criteria: #1.
|
||||
|
||||
Phase 4 closure note (2026-05-26): ROADMAP SC #3 (generate-icons ESM/CJS
|
||||
compatibility under package.json type:module) + SC #4 (dead-code grep —
|
||||
permissions.request absence) both CLOSED via Plan 04-02 (commit f251297).
|
||||
SC #3 closure: `git mv generate-icons.js generate-icons.cjs` (Node 14+
|
||||
treats .cjs as CJS regardless of package.json type:module per
|
||||
nodejs.org/api/packages.html#determining-module-system); `node
|
||||
generate-icons.cjs` exits 0; `npm run build` exits 0. SC #4 closure:
|
||||
tests/build/dead-code-grep.test.ts regression-pins `permissions.request`
|
||||
absence in src/. ALSO: Plan 04-02 4-mechanism layered CSP-hardening
|
||||
mitigation flipped SW chunk `new Function` polarity 1 → 0 (closes Plan
|
||||
01-12 Wave 7 setimmediate polyfill deferred-items entry end-to-end);
|
||||
pre-checkpoint bundle gates 6/6 PASS at every Phase 4 checkpoint boundary;
|
||||
NEW Tier-2 production-bundle filename-leak gate added by Plan 04-08
|
||||
(verifies 0 hits of `synthetic-display-source` in dist/). See
|
||||
04-VERIFICATION.md Per-Requirement Scorecard SC #3 + SC #4 rows + Cross-
|
||||
Cutting Hardening Items rows H1/H3/H4.
|
||||
|
||||
### Performance & Security
|
||||
|
||||
- [x] **REQ-archive-export-latency**: From the moment the user clicks the
|
||||
@@ -319,7 +379,8 @@ RAM-ceiling check.
|
||||
|
||||
---
|
||||
*Requirements defined: 2026-05-15*
|
||||
*Updated 2026-05-20 — Phase 3 closed (REQ-rrweb-dom-buffer + REQ-user-event-log marked Complete via gsd-verifier Phase 3 aggregator; §10 #8 PARTIAL per D-P3-02 + A31 GREEN existing-minimum verification; §10 #9 awaits operator chrome://memory-internals per D-P3-04 + A32 informational scaffolding shipped; UAT harness 29 → 33 GREEN; T5 overrides applied for §10 #4/#5/#8 PARTIAL per saved memory feedback-trust-harness-over-manual-uat.md). VERIFICATION.md at .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VERIFICATION.md.*
|
||||
*Updated 2026-05-26 — Phase 4 closure (executor-created aggregator at .planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md; pending independent gsd-verifier audit + Phase 4 row + completed_phases marker flips). Phase 4 introduced NO new REQs but added verification status notes to REQ-video-ring-buffer (ROADMAP SC #1 via Plan 04-08), REQ-rrweb-dom-buffer (A29 cs-injection-world rewrite via Plan 04-03), REQ-user-event-log (ROADMAP SC #2 + audit P1 #11/#14/#15 via Plan 04-05 + Plan 04-01), REQ-install-clean (ROADMAP SC #3 + SC #4 + Plan 04-02 build hygiene + Plan 04-08 Tier-2 leak gate). UAT harness 33 → 36 GREEN (+A33 + A34 + A35); vitest 171 → 188 GREEN (+17); pre-checkpoint bundle gates 6/6 PASS (Gate 2 polarity flipped 1 → 0); Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12; NEW Tier-2 production-bundle filename-leak gate; 3 /gsd-debug sessions documented; operator-empirical ack 2026-05-26 "Confirmed fixed — close Plan 04-06".*
|
||||
*Earlier update: 2026-05-20 — Phase 3 closed (REQ-rrweb-dom-buffer + REQ-user-event-log marked Complete via gsd-verifier Phase 3 aggregator; §10 #8 PARTIAL per D-P3-02 + A31 GREEN existing-minimum verification; §10 #9 awaits operator chrome://memory-internals per D-P3-04 + A32 informational scaffolding shipped; UAT harness 29 → 33 GREEN; T5 overrides applied for §10 #4/#5/#8 PARTIAL per saved memory feedback-trust-harness-over-manual-uat.md). VERIFICATION.md at .planning/phases/03-spec-10-smoke-verification-dom-event-log-verification/03-VERIFICATION.md.*
|
||||
*Earlier update: 2026-05-20 — REQ-meta-json-schema amended for Plan 02-03 (D-P2-02 + D-P2-03 8-field cutover: `url: string` → `urls: string[]`; new `schemaVersion: "2"` field; F2 empty-array permission). Traceability table entry flipped to "Pending (implementation landed via Plan 02-03; harness validation deferred to Plan 02-04)".*
|
||||
*Earlier update: 2026-05-20 — Plan 01-10 closure (welcome tab; first-install activation; canonical mark + canonical tokens + canonical chrome.i18n welcomeHero; 24/24 UAT GREEN; operator cycle-2 ack "All good"). Plan 01-10 introduced no new functional REQs; it consumed REQ-video-ring-buffer (already Complete via Plan 01-07) by adding the first-install operator-facing activation surface that complements the always-on capture pipeline. Phase 1 final functional plan delivered; final-closure marker flip pending (REQUIREMENTS / ROADMAP / STATE markers + optional /gsd-verify-work 1).*
|
||||
*Earlier update: 2026-05-20 — REQ-install-clean + REQ-manifest-permissions marked Complete on Plan 01-12 closure (design integration + manifest i18n + operator brand-fit ack)*
|
||||
|
||||
@@ -301,7 +301,7 @@ finalized at plan time):
|
||||
- [x] 04-08-PLAN.md — A33 methodology reframe + harness assertion: **CLOSED 2026-05-22** via debug session-2 verdict (canvas-captureStream invisible-source throttling root cause); HTMLVideoElement.captureStream replaces canvas.captureStream in installFakeDisplayMedia() with SYNC install + LAZY first-frame contract; spike re-run produces videoSize=1_797_178 bytes (1.8 MB; vs 8505 baseline); A33 lands per original Plan 04-04 Wave 1 spec under SKIP_LONG_UAT env-gate; UAT 33 -> 34 GREEN. **ROADMAP SC #1 CLOSED.**
|
||||
- [x] 04-05-PLAN.md — A34 fetch + XHR network_error empirical: **CLOSED 2026-05-22.** assertA34 + driveA34 + 3-site orchestrator wiring; cs-injection-world `fetch(404)` + `XMLHttpRequest(404)` from a probe tab; host-side asserts 2 `network_error` entries with `meta.status === 404`. Skip-mode UAT 34 -> 35/35 GREEN (A34 real; all 6 checks PASS). Plan 04-01 P1 #11 Request-narrow fix validated end-to-end (fetch `target` = real URL, not `[object Request]`). **ROADMAP SC #2 CLOSED.** Full-mode 35/35 gate observed a pre-existing Plan 04-08 A33 SAVE-ack flake (A33.1 false; video buffer survived at 1.56 MB) — A34 SKIPPED-not-reached in that run but unaffected; A33 flake routed to /gsd-debug.
|
||||
- [x] 04-06-PLAN.md — Dark-logo currentColor + cursor visibility verification + 01-07-SUMMARY back-patch (UI-SPEC; operator empirical ack): **CLOSED 2026-05-26** via operator re-empirical confirmation "Confirmed fixed — close Plan 04-06". D-P4-03 (both visual polish items) CLOSED. Multi-iteration ceremony: 3 planner passes + 2 checker passes + 1 /gsd-debug fix cycle. Key deliverables: (1) SVG stroke recolor (`stroke="currentColor"`) + welcome.ts `?raw`/DOMParser/replaceChildren inline-SVG injection (no `<img>`, no innerHTML) + globals.d.ts `*.svg?raw` ambient decl; (2) NEW brand-component token `--mks-mark-stroke = var(--mks-linen-50)` in :root (NOT overridden in `.dark`) — decoupled the welcome-hero mark from the theme-flipping semantic `--mks-fg-inverse` token (abstraction error surfaced via Task 4 operator empirical TWEAK; routed via /gsd-debug per `feedback-gsd-ceremony-for-fixes.md`; fix at `a8bcc17`); (3) NEW A35 host-side harness with 5 sub-checks including A35.5 light+dark equality decouple-proof (UAT 35 → 36 GREEN); (4) tests/welcome/inline-svg.test.ts (3 tests) + tests/build/cursor-visibility.test.ts (1 test) — vitest 184 → 188 GREEN; (5) 01-07-SUMMARY back-patch (5 stale 'deferred to Phase 5' framing lines flipped, 4 historical commit-description lines left); (6) deferred-items.md mis-diagnosis correction (04-CONTEXT #9/#10 parallel-vitest flake, NOT strict-meta-json). FORBIDDEN_HOOK_STRINGS unchanged at 12; 6/6 bundle gates PASS. SUMMARY: .planning/phases/04-harden-clean-up-optional/04-06-SUMMARY.md.
|
||||
- [ ] 04-07-PLAN.md — Phase 4 closure aggregator + ROADMAP backfill (D-P4-05) + v1 milestone close prep
|
||||
- [x] 04-07-PLAN.md — Phase 4 closure aggregator + ROADMAP backfill (D-P4-05) + v1 milestone close prep: **CLOSED 2026-05-26.** Plan 04-07 created `.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md` (253 lines; 13 ## sections; 67 Plan 04-0 citations; 9 operator-ack literal hits; 44 commit refs) covering all 8 Phase 4 plans + 3 /gsd-debug sessions + 4 ROADMAP SC closures (SC #1 via Plan 04-08 + SC #2 via Plan 04-05 + SC #3 + SC #4 via Plan 04-02) + 3 audit P1 polish items (#11 + #14 + #15 all via Plan 04-01 D-P4-02) + 6 cross-cutting hardening items + 5/5 D-P4-* charter closures + Phases 1-4 cumulative gate evidence. UAT harness 33 → 36 GREEN (+A33 + A34 + A35; A33 SKIP_LONG_UAT env-gated; A35 5 sub-checks incl. A35.5 light+dark equality decouple-proof). vitest 171 → 188 GREEN (+17 across Plans 04-01/02/06/08). Pre-checkpoint bundle gates 6/6 PASS (Gate 2 polarity flipped 1 → 0 via Plan 04-02 4-mechanism layered mitigation). Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12 entries. NEW Tier-2 production-bundle filename-leak gate added by Plan 04-08. Operator-empirical ack 2026-05-26 verbatim "Confirmed fixed — close Plan 04-06" (Plan 04-06 Task 4 cycle-2 after /gsd-debug fix at commit a8bcc17). D-P4-05 ROADMAP backfill (Plan 01-13 plan-checker flag #4) verified — Plans 01-08..01-14 rows present at ROADMAP.md lines 90-96 with [x] closure annotations; no row additions needed. STATE.md / REQUIREMENTS.md / PROJECT.md marker flips landed atomically with this row flip. Phase 4 row [x] flip + completed_phases bump + status:completed flip DEFERRED to closure ceremony after independent gsd-verifier audit (Phase 1-3 precedent: executor creates VERIFICATION.md; verifier independently re-validates; orchestrator flips post-audit). SUMMARY: .planning/phases/04-harden-clean-up-optional/04-07-SUMMARY.md.
|
||||
|
||||
## Progress
|
||||
|
||||
@@ -313,4 +313,4 @@ Phases execute in numeric order: 1 → 2 → 3 → 4 → 5.
|
||||
| 1. Stabilize video pipeline | 14/14 | **CLOSED 2026-05-20** via gsd-verifier audit GREEN (17/17 must-haves; commit 586836f); all markers flipped | Functional contract closed 2026-05-19 via Plan 01-13 harness PASS; design/brand contract closed 2026-05-20 via Plan 01-12 brand-fit ack; welcome-tab contract closed 2026-05-20 via Plan 01-10 cycle-2 operator ack "All good" + 5 inter-cycle debug fixes |
|
||||
| 2. Stabilize export pipeline | 0/4 | Plans landed 2026-05-20 (4 plans: Wave 0 RED → Wave 1 Blob URL + meta.urls parallel → Wave 2 harness + operator checkpoint); execution pending | - |
|
||||
| 3. SPEC §10 smoke + DOM/event-log verification | 0/TBD | Not started (absorbed Phase-2 DOM verification per 2026-05-20 re-phasing; ~2-3 plans) | - |
|
||||
| 4. Harden + clean up (optional) | 7/8 | In Progress (Plan 04-06 closed D-P4-03 — both visual polish items: cursor visibility verification + dark-surface logo contrast via --mks-mark-stroke brand-component token decoupling; operator re-empirical confirmed 2026-05-26) | |
|
||||
| 4. Harden + clean up (optional) | 8/8 | In Progress (Plan 04-07 closed — Phase 4 closure aggregator created; 04-VERIFICATION.md at .planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md; ALL 4/4 ROADMAP SC + 3/3 audit P1 + 6/6 hardening items GREEN; UAT 36/36 + vitest 188/188 + 6/6 bundle gates + Tier-1=12 + NEW Tier-2; 3 /gsd-debug sessions documented; operator re-empirical 'Confirmed fixed' 2026-05-26; D-P4-05 ROADMAP backfill verified). Phase 4 row [x] flip + completed_phases bump + status:completed flip DEFERRED to closure ceremony after independent gsd-verifier audit — Phase 1-3 precedent. | (pending gsd-verifier audit) |
|
||||
|
||||
@@ -3,15 +3,15 @@ gsd_state_version: 1.0
|
||||
milestone: v2.0.0
|
||||
milestone_name: milestone
|
||||
status: executing
|
||||
stopped_at: "Completed 04-06-PLAN.md (D-P4-03 CLOSED — both visual polish items: cursor visibility verification + dark-surface logo contrast via --mks-mark-stroke brand-component token decoupling; A35 host-side harness with 5 sub-checks including A35.5 light+dark equality decouple-proof; UAT 35->36 GREEN; vitest 184->188; multi-iteration ceremony: 3 planner passes + 2 checker passes + 1 /gsd-debug fix cycle; operator re-empirical confirmed 2026-05-26)"
|
||||
last_updated: "2026-05-26T11:08:13.425Z"
|
||||
stopped_at: "Completed 04-07-PLAN.md (Phase 4 closure aggregator — 04-VERIFICATION.md created end-to-end; 4/4 ROADMAP SC closed; 3/3 audit P1 polish closed; 6/6 cross-cutting hardening items GREEN; UAT 36/36 + vitest 188/188 + 6/6 pre-checkpoint bundle gates + Tier-1=12 + Tier-2 NEW; D-P4-05 ROADMAP backfill verified; STATE.md/ROADMAP.md/REQUIREMENTS.md/PROJECT.md marker flips landed. Phase 4 row + completed_phases bump deferred to closure ceremony post gsd-verifier audit)"
|
||||
last_updated: "2026-05-26T11:30:00Z"
|
||||
last_activity: 2026-05-26
|
||||
progress:
|
||||
total_phases: 4
|
||||
completed_phases: 3
|
||||
total_plans: 31
|
||||
completed_plans: 29
|
||||
percent: 93
|
||||
completed_plans: 30
|
||||
percent: 97
|
||||
---
|
||||
|
||||
# Project State
|
||||
@@ -27,13 +27,24 @@ no server, no password leaks.
|
||||
|
||||
## Current Position
|
||||
|
||||
Phase: 04 (harden-clean-up-optional) — EXECUTING
|
||||
Phase 4 of 4 (Hardening — optional) — Plans 04-01..04-06 + 04-08 closed (7/8); 1 plan remains: 04-07 (Phase 4 closure aggregator + v1 milestone close prep). ROADMAP SC #1 + SC #2 both CLOSED; D-P4-03 CLOSED via Plan 04-06.
|
||||
Plan: 8 of 8 (04-07 NEXT)
|
||||
Status: Ready to execute
|
||||
Phase: 04 (harden-clean-up-optional) — EXECUTING (Plan 04-07 closed; awaiting independent gsd-verifier audit for Phase 4 formal closure ceremony)
|
||||
Phase 4 of 4 (Hardening — optional) — Plans 04-01..04-08 all closed (8/8); Plan 04-07 (this plan) created `.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md` aggregator + marker flips. ROADMAP SC #1 + #2 + #3 + #4 all CLOSED; D-P4-02 + D-P4-03 + D-P4-05 all CLOSED; D-P4-01 + D-P4-04 honored throughout.
|
||||
Plan: 8 of 8 (Plan 04-07 = CLOSED via THIS execution)
|
||||
Status: v1 milestone close-prep complete; pending independent gsd-verifier audit + closure-ceremony marker flips (ROADMAP Phase 4 row [x] + `completed_phases: 3 → 4` + `status: executing → completed` happen at closure ceremony — NOT during this plan)
|
||||
Last activity: 2026-05-26
|
||||
|
||||
Progress: [█████████▒] 93%
|
||||
Progress: [█████████▓] 97%
|
||||
|
||||
### Plan 04-07 closure (2026-05-26)
|
||||
|
||||
- Phase 4 closure aggregator landed end-to-end; 04-VERIFICATION.md created at `.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md` (253 lines; 13 ## sections; 67 Plan 04-0 citations; 9 operator-ack literal hits; 44 commit references). Full coverage of all 8 Phase 4 plans + 3 /gsd-debug sessions + 4 ROADMAP SC closures + 3 audit P1 polish items + 6 cross-cutting hardening items + 5/5 D-P4-* charter closures + Phases 1-4 cumulative gate evidence.
|
||||
- 2 atomic commits planned (Task 1 + Task 2): Task 1 = 04-VERIFICATION.md aggregator commit; Task 2 = REQUIREMENTS.md + ROADMAP.md + STATE.md + PROJECT.md marker flips commit.
|
||||
- SUMMARY: `.planning/phases/04-harden-clean-up-optional/04-07-SUMMARY.md` (created at plan closure).
|
||||
- **Phase 4 cumulative tally:** UAT 33 → 36 GREEN (+A33 + A34 + A35; A33 SKIP_LONG_UAT env-gated; A29 rewritten in-place; A34 always RUNs; A35 5 sub-checks including A35.5 light+dark equality decouple-proof); vitest 171 → 188 GREEN (+17: Plan 04-01 +9, Plan 04-02 +3, Plan 04-06 +4, Plan 04-08 +1); pre-checkpoint bundle gates 6/6 PASS at every checkpoint boundary; Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12; NEW Tier-2 production-bundle filename-leak gate added (Plan 04-08; verifies 0 hits of `synthetic-display-source` in dist/); Gate 2 polarity flipped 1 → 0 (Plan 04-02 4-mechanism layered mitigation closes Plan 01-12 Wave 7 deferred-items entry end-to-end).
|
||||
- **/gsd-debug sessions documented:** 3 sessions (Sessions 1+2 canvas-throttling investigation REFUTED-architecture verdict at commit `4ea1bbb`; Session 3 Plan 04-06 dark-mode mark decoupling resolved at commit `a8bcc17`; Session 4 A33.1 SAVE-ack race resolved at commit `7e0da63`).
|
||||
- **Operator-empirical acks during Phase 4:** Plan 04-06 Task 4 cycle-1 (2026-05-26) TWEAK verdict → /gsd-debug session → fix commit `a8bcc17` → cycle-2 verbatim "Confirmed fixed — close Plan 04-06" (2026-05-26). Canonical operator-empirical case per `feedback-trust-harness-over-manual-uat.md` — aesthetics judgment for dark-mode contrast is the genuinely-non-automatable case.
|
||||
- **D-P4-05 ROADMAP backfill (per Plan 01-13 plan-checker flag #4):** Plans 01-08..01-14 rows verified present at ROADMAP.md lines 90-96 with `[x]` closure annotations; no row additions needed.
|
||||
- **Closure-ceremony deferral:** Phase 4 row flip + `completed_phases` increment + `status: completed` flip are explicitly DEFERRED to the closure ceremony AFTER the independent gsd-verifier audit. This is consistent with Phase 1-3 precedent (executor creates VERIFICATION.md; verifier independently re-validates; orchestrator flips markers post-verifier-audit).
|
||||
|
||||
### Plan 04-06 closure (2026-05-26)
|
||||
|
||||
@@ -186,6 +197,7 @@ Progress: [█████████▒] 93%
|
||||
| Phase 04 P04 | ~25min | - tasks | - files |
|
||||
| Phase 04 P05 | ~45min | 2 tasks | 3 files |
|
||||
| Phase 04 P06 | ~4 days end-to-end (3 planner + 2 checker + 1 /gsd-debug fix cycle; ~6h executor wall-clock across 4 task commits + 1 debug-fix commit) | 4 tasks (3 autonomous + 1 operator empirical with TWEAK→fix→CONFIRMED arc) | 11 modified + 4 created |
|
||||
| Phase 04 P07 | ~15min closure aggregator (read prior SUMMARYs + ROADMAP + REQUIREMENTS + 3 debug sessions; 04-VERIFICATION.md write + marker flips) | 2 tasks (Task 1: 04-VERIFICATION.md; Task 2: marker flips) | 5 files (04-VERIFICATION.md NEW + REQUIREMENTS + ROADMAP + STATE + PROJECT) |
|
||||
|
||||
## Accumulated Context
|
||||
|
||||
@@ -247,6 +259,8 @@ current work:
|
||||
- [Phase 04-06]: Brand-component token vs semantic token abstraction pattern established. `--mks-fg-inverse` is for theme-flipping text foreground (where the surface flips); the welcome-mark wrapper sits on theme-INDEPENDENT madder-600, so a theme-coupled stroke was the wrong abstraction. Fix: introduce a NEW brand-component token `--mks-mark-stroke = var(--mks-linen-50)` in the universal `:root` block + do NOT override in `.dark, [data-theme="dark"]` + rewire `.welcome-hero__mark { color: var(--mks-mark-stroke); }`. SVG remains untouched (currentColor cascade plumbing identical; only wrapper's color source changed). Both themes now resolve computedStroke to rgb(250, 247, 241) (linen-50). The `--mks-fg-inverse` token continues serving its proper role (e.g. src/popup/style.css:39 — theme-flipping surface; LEFT untouched). Pattern: brand-component tokens for theme-independent surfaces; semantic tokens for theme-flipping surfaces.
|
||||
- [Phase 04-06]: Live-DOM host-side harness assertion pattern against welcome.html — NEW A35 driver (driveA35 in tests/uat/lib/harness-page-driver.ts) opens welcome.html as a real Puppeteer tab via browser.newPage() + page.goto(chrome-extension://${extensionId}/src/welcome/welcome.html) + waitForSelector('.welcome-hero__mark svg', ...). Extracted a35Probe(welcomePage, dark) helper toggles documentElement.setAttribute('data-theme', 'dark'|'light') (+ requestAnimationFrame wait) for multi-theme probing. 5 CheckRecords incl. A35.5 light+dark equality decouple-proof. welcomePage.close() in finally block. Pattern reusable for any future welcome.html DOM contract + multi-theme live-DOM check.
|
||||
- [Phase 04-06]: Operator-empirical screenshot harness pattern — per `feedback-trust-harness-over-manual-uat.md`, the operator only judges aesthetics from /tmp/04-06-welcome-hero-{light,dark}.png produced via Puppeteer's Emulation.setEmulatedMedia (prefers-color-scheme: dark). Automation does the rest. scripts/04-06-welcome-hero-screenshots.mjs (194 lines) is the reproducible artifact. The operator's TWEAK verdict on the dark cascade was the surface that catches the abstraction error a planner-checker cannot — encoded the cost-of-empirical-checkpoints lesson.
|
||||
- [Phase 04-07]: Phase 4 closure aggregator landed (`.planning/phases/04-harden-clean-up-optional/04-VERIFICATION.md`; 253 lines; 13 ## sections). All 4 ROADMAP success criteria CLOSED (SC #1 via Plan 04-08, SC #2 via Plan 04-05, SC #3 + SC #4 via Plan 04-02); 3/3 audit P1 polish items CLOSED via Plan 04-01; 6/6 cross-cutting hardening items GREEN. UAT 33 → 36; vitest 171 → 188; pre-checkpoint bundle gates 6/6 PASS (Gate 2 polarity flipped 1 → 0); Tier-1 FORBIDDEN_HOOK_STRINGS unchanged at 12; NEW Tier-2 production-bundle filename-leak gate added by Plan 04-08. 3 /gsd-debug sessions documented (canvas-throttling REFUTED-architecture via sessions 1+2; Plan 04-06 dark-mode mark decoupling; A33.1 SAVE-ack race). 5/5 D-P4-* charter closures (D-P4-01 + D-P4-02 + D-P4-03 + D-P4-05 closed; D-P4-04 alpha out-of-band honored). Operator-empirical ack 2026-05-26: "Confirmed fixed — close Plan 04-06". Plan 04-07 itself executes the canonical Phase N-VERIFICATION.md aggregator pattern + 4 marker file flips (REQUIREMENTS + ROADMAP + STATE + PROJECT). Phase 4 row [x] flip + completed_phases bump + status:completed flip DEFERRED to closure ceremony after the independent gsd-verifier audit — per Phase 1-3 precedent (executor creates VERIFICATION.md; verifier independently re-validates; orchestrator flips markers post-verifier-audit).
|
||||
- [Phase 04-07]: D-P4-05 ROADMAP backfill (Plan 01-13 plan-checker flag #4) CLOSED — Plans 01-08..01-14 ROADMAP.md rows verified present at lines 90-96 with `[x]` closure annotations; no row additions needed. 04-VERIFICATION.md documents the row-by-row verification table.
|
||||
|
||||
### Pending Todos
|
||||
|
||||
@@ -271,11 +285,13 @@ Items acknowledged and carried forward from previous milestone close:
|
||||
|
||||
## Session Continuity
|
||||
|
||||
Last session: 2026-05-26T11:08:13Z
|
||||
Stopped at: Completed 04-06-PLAN.md (D-P4-03 CLOSED — both visual polish items: cursor visibility verification + dark-surface logo contrast via --mks-mark-stroke brand-component token decoupling; A35 host-side harness with 5 sub-checks including A35.5 light+dark equality decouple-proof; UAT 35->36 GREEN; vitest 184->188; multi-iteration ceremony: 3 planner passes + 2 checker passes + 1 /gsd-debug fix cycle; operator re-empirical confirmed 2026-05-26)
|
||||
Last session: 2026-05-26T11:30:00Z
|
||||
Stopped at: Completed 04-07-PLAN.md (Phase 4 closure aggregator — 04-VERIFICATION.md end-to-end; 8/8 Phase 4 plans closed; 4/4 ROADMAP SC + 3/3 audit P1 polish + 6/6 cross-cutting hardening items; UAT 36/36 + vitest 188/188 + 6/6 pre-checkpoint bundle gates + Tier-1=12 + NEW Tier-2; D-P4-05 ROADMAP backfill verified). Phase 4 row flip + completed_phases bump + status:completed deferred to closure ceremony post gsd-verifier audit.
|
||||
Resume file: None
|
||||
|
||||
Prior session: 2026-05-22T10:43:10.855Z — Completed 04-05-PLAN.md (A34 fetch+XHR network_error empirical; ROADMAP SC #2 CLOSED; skip-mode UAT 34->35/35 GREEN; full-mode bailed at pre-existing Plan 04-08 A33 SAVE-ack flake — A34 SKIPPED-not-reached but verified by skip-mode)
|
||||
Prior session: 2026-05-26T11:08:13Z — Completed 04-06-PLAN.md (D-P4-03 CLOSED — both visual polish items: cursor visibility verification + dark-surface logo contrast via --mks-mark-stroke brand-component token decoupling; A35 host-side harness with 5 sub-checks including A35.5 light+dark equality decouple-proof; UAT 35->36 GREEN; vitest 184->188; multi-iteration ceremony: 3 planner passes + 2 checker passes + 1 /gsd-debug fix cycle; operator re-empirical confirmed 2026-05-26)
|
||||
|
||||
Earlier session: 2026-05-22T10:43:10.855Z — Completed 04-05-PLAN.md (A34 fetch+XHR network_error empirical; ROADMAP SC #2 CLOSED; skip-mode UAT 34->35/35 GREEN; full-mode bailed at pre-existing Plan 04-08 A33 SAVE-ack flake — A34 SKIPPED-not-reached but verified by skip-mode)
|
||||
|
||||
Earlier session: 2026-05-21T08:22:59.958Z — /gsd-pause-work saved Phase 4 execution-ready handoff (dbcf482); Phase 4 plans validated iter-2 PASSED + 3 cosmetic advisories fixed
|
||||
Earlier session: 2026-05-20T12:54:42.000Z — /gsd-pause-work saved Phase 2 execution-ready handoff (a440c7d); Phase 1 closed end-to-end via verifier audit GREEN (586836f); alpha distribution shipped (dist-archives/mokosh-build-2026-05-20-6dbed91.zip)
|
||||
|
||||
Reference in New Issue
Block a user