85 lines
6.3 KiB
Markdown
85 lines
6.3 KiB
Markdown
---
|
|
context: phase
|
|
phase: 01-stabilize-video-pipeline
|
|
wave: 2
|
|
plan: 01-09
|
|
status: in_progress (paused mid-fix)
|
|
last_updated: 2026-05-17T14:04:15Z
|
|
---
|
|
|
|
# BLOCKING CONSTRAINTS — Read Before Anything Else
|
|
|
|
These persist from prior sessions and were reaffirmed this session:
|
|
|
|
- [ ] **CONSTRAINT: No unilateral scope reduction** — auto-memory `feedback-no-unilateral-scope-reduction.md`. Surface options via AskUserQuestion or default to FULL scope; never pre-narrow. Apply this to BOTH orchestrator AND when briefing subagents (subagents must not surface their own context anxiety as user-facing decisions).
|
|
- [ ] **CONSTRAINT: GSD ceremony for fixes** — auto-memory `feedback-gsd-ceremony-for-fixes.md`. Route bugs through /gsd-debug; orchestrator does not hot-edit src/.
|
|
- [ ] **CONSTRAINT: Pre-checkpoint bundle gates** — auto-memory `feedback-pre-checkpoint-bundle-gates.md`. Before surfacing any operator empirical checkpoint, run: SW CSP grep (new Function/eval), SW Node-globals grep (Buffer.from), Tier-1 SW-bundle-import gate (`tests/background/sw-bundle-import.test.ts`), manifest validation. Failure = route to /gsd-debug, NOT to operator.
|
|
|
|
Acknowledge each before proceeding.
|
|
|
|
## Recurring anti-pattern this session
|
|
|
|
**Subagent context-anxiety surfacing** — gsd-executor at 66% and gsd-debug-session-manager at 72% both surfaced "should I split / pause" as user-facing decisions despite explicit anti-context-anxiety directives in their spawn prompts. The saved memory covers orchestrator-side surfacing; subagent-side surfacing needs stronger handling. **For next session:** when spawning subagents, include explicit failure-path instructions ("if you genuinely run out: commit clean stopping point + return; orchestrator handles failover via fresh executor — do NOT pause for user decision").
|
|
|
|
---
|
|
|
|
## Current State
|
|
|
|
Phase 01 is mid-Wave-2 (Plan 01-09 closeout):
|
|
|
|
- **Plan 01-08 (WebM remux):** DONE. Resolved via 2-stage fix — resolve.alias for ebml CJS-main + vite-plugin-node-polyfills Buffer polyfill. Commits 5035314..e40949d. Tier-1 SW-bundle-import gate landed (`tests/background/sw-bundle-import.test.ts`, 2 layers).
|
|
- **Plan 01-09 Tasks 1-4:** DONE in code. Commits 333e0dc..c711d7e. 17 new tests GREEN. 81/81 vitest GREEN. tsc clean. Build exit 0.
|
|
- **Plan 01-09 Task 5 operator empirical:** SURFACED 2 BUGS:
|
|
- **Bug A (icon files corrupt placeholders):** unblocked via auto-generated placeholders in working tree (uncommitted). icons/icon{16,48,128}.png at 574/1153/2615 bytes — all above Chrome notification API minimums.
|
|
- **Bug B (`setErrorMode` locks operator out):** state machine routes user-stopped-sharing → setErrorMode → popup stays SAVE-only → toolbar.onClicked won't fire → operator has no restart UI path. Plus recovery notification failed due to Bug A. Operator perception: "recording never stops."
|
|
- **Design intel committed:** .planning/intel/design-system.md + assets-spec.md (commit 949aa03). Designer-team handoff specs.
|
|
- **D-13 trade-off confirmed:** operator reports "some seconds missing in tail." Documented architectural trade-off, NOT a Plan 01-09 regression. Defer to Phase 5 hardening (sub-second rotation OR in-flight inclusion with synthetic Matroska finalization).
|
|
|
|
Test/build baseline at pause:
|
|
- 81/81 vitest GREEN
|
|
- Tier-1 SW-bundle-import gate (Layer 1 + Layer 2) GREEN
|
|
- tsc clean
|
|
- npm run build exit 0
|
|
- Working tree has 5 uncommitted: STATE.md (auto-modified), 3 icon placeholders, tests/fixtures/last_30sec.webm (probably needs revert — verify against HEAD)
|
|
|
|
## Plan 01-10
|
|
|
|
Pending. Wave 3. depends_on: [01-09]. PLAN.md exists at `.planning/phases/01-stabilize-video-pipeline/01-10-PLAN.md`. Unblocked once 01-09 closes.
|
|
|
|
## Next-session order of operations
|
|
|
|
1. **`/gsd-resume-work`** to load HANDOFF.json.
|
|
2. **Verify uncommitted files state:** `git diff tests/fixtures/last_30sec.webm` — if it differs from HEAD (which it probably does because operator's smoke regenerated it), revert: `git checkout HEAD -- tests/fixtures/last_30sec.webm`. The Plan 01-08 fixture committed at e40949d is the canonical one.
|
|
3. **Commit icon placeholders** (Bug A unblock):
|
|
```bash
|
|
git add icons/icon{16,48,128}.png
|
|
git commit -m "fix(01-09): Bug A — auto-generated icon placeholders unblock notification API"
|
|
```
|
|
4. **Spawn fresh /gsd-debug session for Bug B** with explicit anti-context-anxiety directive in the prompt. Use this prompt skeleton:
|
|
- slug: `01-09-recovery-flow`
|
|
- Bug B specifics: route src/background/index.ts:725-744 RECORDING_ERROR handler on `message.error` code — `'user-stopped-sharing'` → `setIdleMode()`; other codes → `setErrorMode()` (preserved).
|
|
- All 3 hypotheses already empirically verified (per prior session manager's checkpoint return); fresh session can skip verification phase and go straight to RED test + GREEN fix.
|
|
- RED test belongs in `tests/background/badge-state-machine.test.ts` (extend with routed-error-code case).
|
|
5. **Pre-checkpoint gates** (per saved memory) BEFORE re-surfacing operator UAT.
|
|
6. **Operator UAT re-run** to confirm Bug A + Bug B fixed.
|
|
7. **Wave 3: `/gsd-execute-phase 1`** continues to Plan 01-10.
|
|
8. **`/gsd-verify-work 1`** goal-backward.
|
|
9. **Phase 1 closure markers flip:** REQUIREMENTS.md [ ] → [x], ROADMAP [ ] → [x], STATE.md phase_reopened → phase_complete.
|
|
|
|
## Required reading (in order)
|
|
|
|
1. `.planning/HANDOFF.json` — structured state
|
|
2. `.planning/intel/design-system.md` + `.planning/intel/assets-spec.md` — design specs for designer team
|
|
3. `src/background/index.ts` lines 54 (NOTIFICATION_ICON_PATH), 85-108 (state machine), 725-744 (RECORDING_ERROR handler — fix target), 833-840 (startup notification)
|
|
4. `src/offscreen/recorder.ts` lines 451-480 (onUserStoppedSharing — confirms resetBuffer happens)
|
|
5. `.planning/phases/01-stabilize-video-pipeline/01-09-PLAN.md` — full Plan 01-09 spec
|
|
6. `tests/background/badge-state-machine.test.ts` — RED test target for Bug B
|
|
|
|
## Infrastructure state
|
|
|
|
- Branch: `gsd/phase-01-stabilize-video-pipeline`, currently at `949aa03` (head)
|
|
- vite.config.ts has Buffer polyfill + ebml alias (Plan 01-08 critical fixes; do not touch)
|
|
- smoke.sh has timer overlay (commit 923aaca) AND SHARE_TARGET="Entire screen" (Plan 01-09); preserve both
|
|
- manifest.json has `notifications` permission (Plan 01-09)
|
|
- Tier-1 SW-bundle-import gate is the automation contract for ALL future bundle-touching changes
|