Mark
3f8e31a329
Closes the iter-2 BLOCKER 1 resolution end-to-end: the inline-SVG
strategy now has HONEST automated coverage at two layers — source
contract (Task 1 unit tests + the narrowed A17.8 source-bundling
grep) and live-DOM cascade (the NEW host-side A35 harness assertion
that opens welcome.html as a real Puppeteer tab).
- tests/uat/extension-page-harness.ts (A17.8 NARROWED HONESTLY):
swap the data:image/svg+xml URL-grep + .svg filename-grep target
for a raw-source grep — A17.8 now asserts the welcome chunk JS
contains the raw SVG signature `stroke="currentColor"` AND the
canonical `viewBox="0 0 32 32"` (the `?raw` import's output). The
explanatory comment block now DISAVOWS the live-DOM claim and
points at the NEW A35 driver for the runtime injection + cascade
proof. A17.8 is honest source-bundling only.
- tests/uat/lib/harness-page-driver.ts (NEW host-side driveA35):
appended LAST per the iter-2 ADV-2C concern (any driver-pollution
worry is moot since nothing reads A35's return value, AND
welcomePage.close() in finally guarantees no tab leak). driveA35
opens chrome-extension://<id>/src/welcome/welcome.html in a fresh
browser.newPage() tab, waits for the `.welcome-hero__mark svg`
selector at DOMContentLoaded, then runs a single page.evaluate()
that reads four signals: A35.1 inline <svg> present, A35.2
stroke=currentColor, A35.3 getComputedStyle().stroke resolves to
a non-default colour (the real cascade proof), A35.4 no legacy
<img> in the slot. Host-side pattern mirrors driveA32/A33/A34.
- tests/uat/harness.test.ts (orchestrator wiring):
+ driveA35 added to the import block from './lib/harness-page-driver'.
+ driveA35Wrapped closure capturing handles.browser + handles.extensionId
(alongside driveA33Wrapped/driveA34Wrapped).
+ { name: 'A35', drive: driveA35Wrapped } appended as the LAST
entry of the `drivers` array. Total auto-increments via
`drivers.length + 1` (line 580) — no hardcoded count to bump.
+ Architecture banner string (line 283) refreshed with A33, A34,
A35 inline (ADV-2A cosmetic advisory — banner was already stale
pre-04-06; A33+A34 added at the same time).
- .planning/phases/01-stabilize-video-pipeline/01-07-SUMMARY.md
(back-patch, DEFECT 2 resolution):
Flipped 5 lines (22, 47, 82, 135, 205) that carried the now-stale
"deferred to Phase 5" framing for cursor visibility — the
`cursor: 'always'` constraint was opportunistically shipped in
Plan 01-09 (recorder.ts:285) and is verified by Plan 04-06 Task 1
(tests/build/cursor-visibility.test.ts). Each flip is surgical
(single line / single bullet, with explicit "back-patched in
Phase 4 Plan 04-06" citation). Historical commit-description
lines 40, 89, 109, 110 are LEFT unchanged — they describe what
the Phase-1-closure commits literally did at the time, not
forward-looking deferrals.
- .planning/phases/04-harden-clean-up-optional/deferred-items.md
(correction, BLOCKER 2 resolution):
Corrected the misdiagnosed entry from commit 6a989e8. The prior
entry named tests/build/strict-meta-json-validation.test.ts as
failing on a clean tree — that diagnosis was WRONG (the test is
8/8 GREEN in isolation). The real root cause is the pre-existing
04-CONTEXT #9 + #10 parallel-vitest / ffprobe-timeout flake
family (lands non-deterministically on whichever ffprobe / race
test loses the worker race; observed instance this session was
tests/background/webm-remux.test.ts > ffprobe -count_frames,
which is also 5/5 GREEN in isolation). True clean baseline is
184/184 GREEN; 188/188 after Plan 04-06's +4 new tests.
Gates run:
- npx tsc --noEmit exit 0.
- npm run build:test exit 0; dist-test/assets/welcome-CMygHJ_J.js
carries the raw SVG source.
- HEADLESS=1 SKIP_PROD_REBUILD=0 SKIP_LONG_UAT=1 npm run test:uat:
36/36 UAT assertions GREEN (was 35/35; +A35). A17.8 PASS:
currentColorStroke=true, canonicalViewBox=true. A35 live-DOM
probe: svgPresent=true strokeAttr=currentColor
computedStroke="rgb(250, 247, 241)" (linen-50, the
--mks-fg-inverse value flowing through the cascade — the
currentColor strategy WORKS in real Chrome) imgPresent=false.
- All Task 3 acceptance greps PASS: driveA35 count in
harness-page-driver.ts=5, in harness.test.ts=6; name:'A35'=1;
getComputedStyle=6; stroke="currentColor" in
extension-page-harness.ts=4; data:image/svg+xml=0 (grep target
and comment refs both removed).
References:
- 04-06-PLAN.md iter-2 BLOCKER 1 + BLOCKER 2 resolutions.
- .planning/phases/04-harden-clean-up-optional/04-UI-SPEC.md
§"Implementation amendment" (Option A currentColor + inline-SVG).
10 lines
2.2 KiB
Markdown
10 lines
2.2 KiB
Markdown
# Phase 04 — Deferred Items (out-of-scope discoveries during execution)
|
|
|
|
Items discovered during plan execution that are NOT caused by the current
|
|
plan's changes. Logged per the executor scope-boundary rule; NOT fixed in
|
|
the discovering plan.
|
|
|
|
| Item | Discovered During | Description | Disposition |
|
|
|------|-------------------|-------------|-------------|
|
|
| Non-deterministic parallel-vitest / ffprobe-timeout flake family (04-CONTEXT.md in-scope items #9 + #10) | Plan 04-06 baseline check (2026-05-22; corrected 2026-05-26 in Plan 04-06 Task 3) | Full `npx vitest run` intermittently produces **183 passed / 1 failed (184 total)** on a clean tree. The "1 failed" lands non-deterministically on whichever ffprobe / parallel-worker race test loses the worker race — observed instances include `tests/background/webm-remux.test.ts > ffprobe -count_frames reports between 905 and 912 frames inclusive` (`Error: Test timed out in 5000ms`). Both `webm-remux.test.ts` (5/5) and `tests/build/strict-meta-json-validation.test.ts` (8/8) pass deterministically when run in isolation (`npm test -- <file> --run`). **CORRECTION**: a prior version of this entry (commit `6a989e8`) named `strict-meta-json-validation.test.ts` as failing on a clean tree — that diagnosis was wrong; that test is GREEN in isolation. The real root cause is the pre-existing **04-CONTEXT #9** (parallel-vitest Tier-1-build-step race; ~1/5 full-suite runs) + **#10** (2 ffprobe/ffmpeg vitest flakes), which are already enumerated as in-scope items in `04-CONTEXT.md`. The true clean baseline is **184/184 GREEN** (188/188 after Plan 04-06 adds 4 new tests). Plan 04-06 Task 2's VITEST GATE LOGIC tolerates a single isolation-passing flake (NOT a hard-coded named test) and FAILS on any reproducible-in-isolation failure or 2+ failures. | Out of scope for Plan 04-06. Routed as "04-CONTEXT #9/#10 parallel-vitest ffprobe flake family" (NOT as "strict-meta-json fails on a clean tree" — that prior diagnosis is wrong). If a `/gsd-debug` is opened, route to the parallel-vitest worker-isolation strategy (the canonical Vitest mitigation is `poolOptions.threads.singleThread:true` for the affected files, OR raising `testTimeout` on the ffprobe `it.skipIf` block). Do NOT fix in Plan 04-06. |
|