strategy155
  • Joined on 2025-02-20
strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Quite a bad naming here.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

horrible cryptic piece of bloated mess

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

unclear lifecycle, we need to fix it!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

All the config names and fields should be revised, the configs themselves should be typed through pydantic potentially.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

inline operation = bad.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

those functions are quite strange

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

either enum here, or REDO completely.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

NAMING!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

some problems I see here as welll.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

it is better, but please use normal intermediate variables operations, and the constants as keys. OR maybe to pydantic dataclasses we go?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

not normal, should be put to constant, or even better this system should be revound.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Probably you also need to comment on the calsss tacttrbute,s per rgoogle codestyle no?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

whait is this.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

all about it is horrible.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

bad practice

strategy155 created pull request veles/marketTrade#1 2025-11-24 18:57:10 +00:00
refactor/code-style-standardization
strategy155 pushed to dev at veles/marketTrade 2025-11-24 18:56:24 +00:00
strategy155 created branch dev in veles/marketTrade 2025-11-24 18:56:24 +00:00
strategy155 pushed to refactor/code-style-standardization at veles/marketTrade 2025-11-24 18:56:11 +00:00
5977ed5c15 various fixes
strategy155 created branch refactor/code-style-standardization in veles/marketTrade 2025-11-24 18:49:34 +00:00