strategy155
1 Followers · 1 Following
  • Joined on 2025-02-20
Repositories Projects Packages Public Activity Starred Repositories
strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

enums enums enumS!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

is it a goodpattersn thoug'h, maybe we can formalise the dispatching scheme better?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

maybe more enums for things like this one?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

bloody hell

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

this file probably should be named properly, and if mained.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Horrible naming.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

All the operations like this should be decopupled, the variabels inside should be named properly, the keys in the dicts should be explicit and moved to constants. Along all places.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Quite a bad naming here.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

horrible cryptic piece of bloated mess

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

unclear lifecycle, we need to fix it!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

All the config names and fields should be revised, the configs themselves should be typed through pydantic potentially.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

inline operation = bad.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

those functions are quite strange

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

either enum here, or REDO completely.

strategy155 created pull request veles/marketTrade#1 2025-11-24 18:57:10 +00:00
refactor/code-style-standardization
strategy155 created branch dev in veles/marketTrade 2025-11-24 18:56:24 +00:00
strategy155 pushed to dev at veles/marketTrade 2025-11-24 18:56:24 +00:00
strategy155 pushed to refactor/code-style-standardization at veles/marketTrade 2025-11-24 18:56:11 +00:00
5977ed5c15 various fixes
strategy155 pushed to refactor/code-style-standardization at veles/marketTrade 2025-11-24 18:49:34 +00:00
159095ce5a chore: finalize file rename by removing old CoreTraidMath.py
92eb7db4c5 refactor: update test file to use new standardized method names
bfa0d13a25 refactor: standardize DecisionManager, DealManager, and RiskManager
00c7614bfc fix: correct class name typos and variable naming issues
bbba7bfe89 refactor: rename CoreTraidMath.py to CoreTradeMath.py
Compare 10 commits »
strategy155 created branch refactor/code-style-standardization in veles/marketTrade 2025-11-24 18:49:34 +00:00