strategy155
  • Joined on 2025-02-20
strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

is it a goodpattersn thoug'h, maybe we can formalise the dispatching scheme better?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

maybe more enums for things like this one?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

bloody hell

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

this file probably should be named properly, and if mained.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Horrible naming.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

All the operations like this should be decopupled, the variabels inside should be named properly, the keys in the dicts should be explicit and moved to constants. Along all places.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Quite a bad naming here.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

horrible cryptic piece of bloated mess

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

unclear lifecycle, we need to fix it!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

All the config names and fields should be revised, the configs themselves should be typed through pydantic potentially.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

inline operation = bad.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

those functions are quite strange

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

either enum here, or REDO completely.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

NAMING!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

some problems I see here as welll.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

it is better, but please use normal intermediate variables operations, and the constants as keys. OR maybe to pydantic dataclasses we go?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

not normal, should be put to constant, or even better this system should be revound.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Probably you also need to comment on the calsss tacttrbute,s per rgoogle codestyle no?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

whait is this.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

all about it is horrible.